Re: Review request 8002212 - adding read/writeObject to additional SerialXXX classes -- Updated

2012-11-03 Thread Lance Andersen - Oracle
I revised the webrev, http://cr.openjdk.java.net/~lancea/8002212/webrev.01, taking into account the vast majority of Remi's suggestions. I also added SerialStruct to the webrev. Have a great weekend. Best Lance On Nov 2, 2012, at 7:42 PM, Remi Forax wrote: On 11/02/2012 11:57 PM, Lance

Re: Review request 8002212 - adding read/writeObject to additional SerialXXX classes

2012-11-03 Thread Lance Andersen - Oracle
On Nov 3, 2012, at 11:14 AM, Remi Forax wrote: On 11/03/2012 01:46 AM, Lance Andersen - Oracle wrote: Hi Remi, [...] In SerialDataLink, do you really need readObject/writeObject given that you call the default implementations. I thought about that but had decided to add them for

Re: Review request 8002212 - adding read/writeObject to additional SerialXXX classes -- Updated

2012-11-03 Thread Remi Forax
On 11/03/2012 03:11 PM, Lance Andersen - Oracle wrote: I revised the webrev, http://cr.openjdk.java.net/~lancea/8002212/webrev.01, taking into account the vast majority of Remi's suggestions. in SerialJavaObject, hasStaticFields doesn't work, the original code doesn't work because it only

Re: Review request 8002212 - adding read/writeObject to additional SerialXXX classes -- Updated

2012-11-03 Thread Lance Andersen - Oracle
On Nov 3, 2012, at 11:34 AM, Remi Forax wrote: On 11/03/2012 03:11 PM, Lance Andersen - Oracle wrote: I revised the webrev, http://cr.openjdk.java.net/~lancea/8002212/webrev.01, taking into account the vast majority of Remi's suggestions. in SerialJavaObject, hasStaticFields doesn't work,

Re: Review request 8002212 - adding read/writeObject to additional SerialXXX classes -- Updated

2012-11-03 Thread Remi Forax
On 11/03/2012 05:23 PM, Lance Andersen - Oracle wrote: On Nov 3, 2012, at 11:34 AM, Remi Forax wrote: On 11/03/2012 03:11 PM, Lance Andersen - Oracle wrote: I revised the webrev, http://cr.openjdk.java.net/~lancea/8002212/webrev.01, taking into account the vast majority of Remi's

Review request 8002212 - adding read/writeObject to additional SerialXXX classes

2012-11-02 Thread Lance Andersen - Oracle
This is similar to 8001536, just additional classes. This adds read/writeObject, equals, clone methods to additional SerialXXX classes SQE, JCK and JDBC Unit tests all pass. The webrev can be viewed at http://cr.openjdk.java.net/~lancea/8002212/webrev.00 Best Lance Lance Andersen| Principal

Re: Review request 8002212 - adding read/writeObject to additional SerialXXX classes

2012-11-02 Thread Remi Forax
On 11/02/2012 11:57 PM, Lance Andersen - Oracle wrote: This is similar to 8001536, just additional classes. This adds read/writeObject, equals, clone methods to additional SerialXXX classes SQE, JCK and JDBC Unit tests all pass. The webrev can be viewed at

Re: Review request 8002212 - adding read/writeObject to additional SerialXXX classes

2012-11-02 Thread Lance Andersen - Oracle
Hi Remi, Thank you for the feedback On Nov 2, 2012, at 7:42 PM, Remi Forax wrote: On 11/02/2012 11:57 PM, Lance Andersen - Oracle wrote: This is similar to 8001536, just additional classes. This adds read/writeObject, equals, clone methods to additional SerialXXX classes SQE, JCK and