Re: Review request 8145409: Better detect JRE that JLI will be using

Hi Dmitry, Approved. Please make sure all the core tests are run using jprt and integrate this into jdk9/dev, if you can't do so, let me know. Thanks Kumar On 1/13/2016 4:06 AM, Dmitry Cherepanov wrote: Hi Kumar, Thanks for the comments. On 1/12/16 9:21 PM, Kumar Srinivasan wrote: Hi Dmitr

Re: Review request 8145409: Better detect JRE that JLI will be using

Hi Kumar, Thanks for the comments. On 1/12/16 9:21 PM, Kumar Srinivasan wrote: Hi Dmitry, src/java.base/windows/native/libjli/java_md.c 1) use NULL -GetModuleFileName(0, buf, bufsize); +GetModuleFileName(NULL, buf, bufsize); OK. 2) extra LF ? + * Removes the trailing file name

Re: Review request 8145409: Better detect JRE that JLI will be using

Hi Dmitry, src/java.base/windows/native/libjli/java_md.c 1) use NULL -GetModuleFileName(0, buf, bufsize); +GetModuleFileName(NULL, buf, bufsize); 2) extra LF ? + * Removes the trailing file name and one sub-folder from a path. + * + * If buf is "c:\foo\bin\javac", then put "c:\foo"

Review request 8145409: Better detect JRE that JLI will be using

Hello, Please review the following patch https://bugs.openjdk.java.net/browse/JDK-8145409 http://cr.openjdk.java.net/~dcherepanov/8145409/webrev.v0/ The patch improves GetJREPath() on Windows and implements a fallback for applications with custom native launcher and private JRE. Thanks, Dmi