Re: Review request for 6927486: Deadlock in legacy Hashtable writeObject()

2011-02-11 Thread Mike Duigou
Everything looks resolved to me as well. I will push this webrev over the weekend or on Monday. Thank you for your patience in working through the pedantic details. Hopefully this will make the process smoother for all future commits and we won't have to revisit any of these issues. Mike On Fe

Re: Review request for 6927486: Deadlock in legacy Hashtable writeObject()

2011-02-11 Thread Alan Bateman
Neil Richards wrote: Hi Alan, Mike, Please find attached a further webrev zip file with the IBM copyright split out into its own little comment block, as requested. Good to see this finally resolved. Thumbs up from me. Mike has offered to push this so I'll leave it to him. Also I assume this

Re: Review request for 6927486: Deadlock in legacy Hashtable writeObject()

2011-02-09 Thread Alan Bateman
Neil Richards wrote: Hi Alan, Mike, Please find attached one more webrev zip, with updated license text and now based off jdk7-b128. Let me know if this is now good to be committed, or if there's anything else I need to do, Thanks, Neil Thanks for perceiving with this. The only thing that loo

Re: Review request for 6927486: Deadlock in legacy Hashtable writeObject()

2011-01-10 Thread Alan Bateman
Neil Richards wrote: : Okay. I've updated the changeset to do this too, and attached this as a webrev zip file (as per Dalibor's suggestion). Please review this modified changeset, and let me know if anything further is required for its acceptance. Looks fine to me. As per the tests for the

Re: Review request for 6927486: Deadlock in legacy Hashtable writeObject()

2011-01-05 Thread Stuart Marks
On 1/5/11 5:36 AM, Alan Bateman wrote: I've taken the liberty to generate a webrev from the changeset, just to make it a bit easier for folks to browse and review. http://cr.openjdk.java.net/~alanb/6927486/webrev/ I don't see any issues with the changes to j.u.Hashtable. You might have seen Stua

Re: Review request for 6927486: Deadlock in legacy Hashtable writeObject()

2011-01-05 Thread Alan Bateman
Neil Richards wrote: Please find attached a changeset to address the problem reported in bug 6927486, "Deadlock in legacy Hashtable writeObject()". I've taken the liberty to generate a webrev from the changeset, just to make it a bit easier for folks to browse and review. http://cr.openjdk.

Re: Review request for 6927486: Deadlock in legacy Hashtable writeObject()

2010-12-22 Thread Dalibor Topic
On 12/22/10 12:19 PM, Neil Richards wrote: > On 22 December 2010 09:38, David Holmes wrote: >> Hi Neil, >> >> Any chance you can generate webrevs as mentioned in: >> >> http://openjdk.java.net/guide/changePlanning.html > > Hi David, >>From the documentation, I don't believe I can do so yet. > H

Re: Review request for 6927486: Deadlock in legacy Hashtable writeObject()

2010-12-22 Thread Neil Richards
On 22 December 2010 09:38, David Holmes wrote: > Hi Neil, > > Any chance you can generate webrevs as mentioned in: > > http://openjdk.java.net/guide/changePlanning.html Hi David, >From the documentation, I don't believe I can do so yet. http://cr.openjdk.java.net/ (referred to from the page you

Review request for 6927486: Deadlock in legacy Hashtable writeObject()

2010-12-21 Thread Neil Richards
Please find attached a changeset to address the problem reported in bug 6927486, "Deadlock in legacy Hashtable writeObject()". The problem reported is similar to one found in java.util.Vector, for which a fix is also currently under review (http://mail.openjdk.java.net/pipermail/core-libs-dev/2010