Thanks for the comments
On Jun 13, 2012, at 6:03 PM, Ulf Zibis wrote:
>
> Am 13.06.2012 13:04, schrieb Lance Andersen - Oracle:
>> Hi Paul,
>>
>> Thank you for taking the time to review the code.
>>
>>
>> I made the change you suggested below
>>
>> http://cr.openjdk.java.net/~lancea/7145913/
Am 13.06.2012 13:04, schrieb Lance Andersen - Oracle:
Hi Paul,
Thank you for taking the time to review the code.
I made the change you suggested below
http://cr.openjdk.java.net/~lancea/7145913/webrev.02
Typos:
912 * Hence we cannot exactly identify why the insertion faile
On 06/13/2012 07:01 PM, Lance Andersen - Oracle wrote:
Hi Remi,
Thank you for the suggestion. Over the years, I have gotten different
views on whether to have multiple return points vs just one.
Is there a specific style preference that should be used going
forward? At this time, I would
Hi Remi,
Thank you for the suggestion. Over the years, I have gotten different views on
whether to have multiple return points vs just one.
Is there a specific style preference that should be used going forward? At
this time, I would prefer to not make another change and if the consensus
g
On 06/13/2012 06:18 PM, Joe Wang wrote:
Hi Lance,
The changes look good to me.
Joe
Hi Lance,
just a minor comment, in isPKNameValid, you don't need the boolean
isValid because
you can return true instead of using break and return false at the end.
cheers,
Rémi
On 6/13/2012 4:09 AM, Paul
Hi Lance,
The changes look good to me.
Joe
On 6/13/2012 4:09 AM, Paul Sandoz wrote:
On Jun 13, 2012, at 1:04 PM, Lance Andersen - Oracle wrote:
Hi Paul,
Thank you for taking the time to review the code.
I made the change you suggested below
http://cr.openjdk.java.net/~lancea/7145913/webr
On Jun 13, 2012, at 1:04 PM, Lance Andersen - Oracle wrote:
> Hi Paul,
>
> Thank you for taking the time to review the code.
>
>
> I made the change you suggested below
>
> http://cr.openjdk.java.net/~lancea/7145913/webrev.02
>
> Let me know if you are good with the change and I will get this
Hi Paul,
Thank you for taking the time to review the code.
I made the change you suggested below
http://cr.openjdk.java.net/~lancea/7145913/webrev.02
Let me know if you are good with the change and I will get this puppy put back.
Best
Lance
On Jun 13, 2012, at 3:53 AM, Paul Sandoz wrote:
>
Hi Lance,
It looks OK to me, however i don't know much about JDBC. Much cleaner than
before.
Very minor point, you can shoot me for being pedantic!: from line 894 you can
do the following since the return value from pstmt.executeUpdate() is never
used:
894try {
895
view request for 7145913 CachedRowSetSwriter.insertNewRow()
> throws SQLException
>
> Still looking for reviewer
>
> Best
> Lance
>
> Begin forwarded message:
>
>> From: Lance Andersen - Oracle
>> Date: May 31, 2012 6:16:16 PM EDT
>> Cc: core-l
Still looking for reviewer
Best
Lance
Begin forwarded message:
> From: Lance Andersen - Oracle
> Date: May 31, 2012 6:16:16 PM EDT
> Cc: core-libs-dev core-libs-dev
> Subject: Re: Review request for 7145913 CachedRowSetSwriter.insertNewRow()
> throws SQLException
>
>
Here is the revision using the try with resources as David suggested
http://cr.openjdk.java.net/~lancea/7145913/webrev.01/
Best
Lance
On May 31, 2012, at 3:10 PM, David Schlosnagle wrote:
> On Thu, May 31, 2012 at 1:50 PM, Lance Andersen - Oracle
> wrote:
>> Hi,
>>
>> Looking for a reviewer fo
Hi David,
Thanks for the feedback
On May 31, 2012, at 3:10 PM, David Schlosnagle wrote:
> On Thu, May 31, 2012 at 1:50 PM, Lance Andersen - Oracle
> wrote:
>> Hi,
>>
>> Looking for a reviewer for 7145913. This addresses an issue with where a
>> SQLException could be thrown when writing a row
On Thu, May 31, 2012 at 1:50 PM, Lance Andersen - Oracle
wrote:
> Hi,
>
> Looking for a reviewer for 7145913. This addresses an issue with where a
> SQLException could be thrown when writing a row back with an auto-incremented
> column on some databases.
>
> Webrev is http://cr.openjdk.java.net
Hi,
Looking for a reviewer for 7145913. This addresses an issue with where a
SQLException could be thrown when writing a row back with an auto-incremented
column on some databases.
Webrev is http://cr.openjdk.java.net/~lancea/7145913/webrev.00/. RowSet TCK,
sqe tests and unit tests all pass
15 matches
Mail list logo
