On 31/10/2012 15:08, Lance Andersen - Oracle wrote:
Here is revised webrev taking into account Remi's suggestions
http://cr.openjdk.java.net/~lancea/8001536/webrev.01/
I skimmed over the updated webrev and the changes mostly look okay to me.
One comment on the clone method is that "The inter
On 10/31/2012 04:08 PM, Lance Andersen - Oracle wrote:
Here is revised webrev taking into account Remi's suggestions
http://cr.openjdk.java.net/~lancea/8001536/webrev.01/
looks good :)
Best,
Lance
Rémi
On Oct 30, 2012, at 2:05 PM, Remi Forax wrote:
On 10/30/2012 05:25 PM, Lance Anders
Here is revised webrev taking into account Remi's suggestions
http://cr.openjdk.java.net/~lancea/8001536/webrev.01/
Best,
Lance
On Oct 30, 2012, at 2:05 PM, Remi Forax wrote:
> On 10/30/2012 05:25 PM, Lance Andersen - Oracle wrote:
>> Hi,
>>
>> This is a request for review of
>> http://cr.o
On 10/30/2012 07:53 PM, Lance Andersen - Oracle wrote:
Hi Remi,
Thank you for the feedback
On Oct 30, 2012, at 2:05 PM, Remi Forax wrote:
On 10/30/2012 05:25 PM, Lance Andersen - Oracle wrote:
Hi,
This is a request for review of
http://cr.openjdk.java.net/~lancea/8001536/webrev.00/. This
On 30/10/2012 18:05, Remi Forax wrote:
in writeObject, you set "blob" twice, which is weird, also I think
that if blob is not Serializable,
the code should throw an exception, so you should not use instanceof
and let s.writeFields()
to throw NotSerializable exception.
Yes, that is odd. I thin
Point taken Ulf, thank you for the feedback and will follow your suggestion
going forward , which I typically do, but I think I am still feeling the
effects of being offline due to hurricane sandy :-(
Best
Lance
On Oct 30, 2012, at 2:50 PM, Ulf Zibis wrote:
> Thanks Lance.
>
> But having the
Hi Remi,
Thank you for the feedback
On Oct 30, 2012, at 2:05 PM, Remi Forax wrote:
> On 10/30/2012 05:25 PM, Lance Andersen - Oracle wrote:
>> Hi,
>>
>> This is a request for review of
>> http://cr.openjdk.java.net/~lancea/8001536/webrev.00/. This adds
>> read/writeObject as well as clone m
Thanks Lance.
But having the subject of the request in clear text in the list view of the email client would be a
great help.
-Ulf
Am 30.10.2012 19:28, schrieb Lance Andersen - Oracle:
Hi Ulf,
The bug is described below, it is just adding the read/writeObject and clone
methods.
Best
Lanc
Hi Ulf,
The bug is described below, it is just adding the read/writeObject and clone
methods.
Best
Lance
On Oct 30, 2012, at 2:18 PM, Ulf Zibis wrote:
> Hi all,
>
> please add the bug summary to the subject line.
> Bug 8001536 is not publicly visible :-(
>
> -Ulf
>
> Am 30.10.2012 17:25, sc
Hi all,
please add the bug summary to the subject line.
Bug 8001536 is not publicly visible :-(
-Ulf
Am 30.10.2012 17:25, schrieb Lance Andersen - Oracle:
Hi,
This is a request for review of
http://cr.openjdk.java.net/~lancea/8001536/webrev.00/. This adds
read/writeObject as well as clone
On 10/30/2012 05:25 PM, Lance Andersen - Oracle wrote:
Hi,
This is a request for review of
http://cr.openjdk.java.net/~lancea/8001536/webrev.00/. This adds
read/writeObject as well as clone methods to SerialXLob classes.
All SQE tests passed, 1 failure in the RowSet JCK/TCK tests due to a b
Hi,
This is a request for review of
http://cr.openjdk.java.net/~lancea/8001536/webrev.00/. This adds
read/writeObject as well as clone methods to SerialXLob classes.
All SQE tests passed, 1 failure in the RowSet JCK/TCK tests due to a bug in
the test that the TCK team is aware of and will ad
12 matches
Mail list logo
