Hi,

the HashSet used for the script engine factories caused the random behaviour.

Bug:
https://bugs.openjdk.java.net/browse/JDK-8011697

Webrev:
http://cr.openjdk.java.net/~arieber/8011697/webrev.01/

Please review and sponsor required...

thanks
Andreas


On 19.09.2013 08:55, Andreas Rieber wrote:
Hi Sundar,

On 19.09.2013 08:34, A. Sundararajan wrote:
Hi,

Few comments on this:

1) This is a JDK repo (where javax.script lives) change and so core-libs-dev review is needed
will do that (when i have 3).

2) Not sure if it affects any word on spec. - need to go through spec + javadoc comments closely
I checked the javadoc, there is nothing mentioned about the internal implementation of the script engine factories. So this should be fine.

3) You need a test that demonstrates that order is preserved
I will try to setup a test with your sample script engine attached to the issue.


Hope this helps,
-Sundar
thanks
Andreas


On Thursday 19 September 2013 11:43 AM, Andreas Rieber wrote:
Hi,

the HashSet used for the script engine factories caused the random behaviour.

Bug:
https://bugs.openjdk.java.net/browse/JDK-8011697

Webrev:
http://cr.openjdk.java.net/~arieber/8011697/webrev.00/

Please review and sponsor required...

thanks
Andreas




Reply via email to