> http://cr.openjdk.java.net/~fyuan/8051560/webrev.01/
>
> I am not sure which is other insight you mentioned, would you like to explain
> more?
>
> Best Regareds
> Frank
>
> From: huizhe wang [mailto:huizhe.w...@oracle.com]
> Sent: Tuesday, March 31, 2015 1
]
> Sent: Tuesday, March 31, 2015 10:14 AM
> To: Frank Yuan
> Cc: 'Lance Andersen'; 'Core-Libs-Dev'; 'Gustavo Galimberti'
> Subject: Re: Review request for JDK-8051560: JAXP function astro tests
> conversion
>
> Hi Frank,
>
> Looks good.
&
er here:)
Best Regards
Frank
*From:*huizhe wang [mailto:huizhe.w...@oracle.com]
*Sent:* Friday, March 27, 2015 9:02 AM
*To:* Lance Andersen
*Cc:* Frank Yuan; 'Core-Libs-Dev'; 'Gustavo Galimberti'
*Subject:* Re: Review request for JDK-8051560: JAXP function astro
tests conv
Please also describe the mapping of the original tests and the new ones
so that we are sure no test cases are lost in the transition.
Thanks,
Joe
On 3/26/2015 6:01 PM, huizhe wang wrote:
I second Lance. The Main of the original astro had Javadocs and
developer comments. Probably more important
I second Lance. The Main of the original astro had Javadocs and
developer comments. Probably more important is that you've completely
changed the main classes (TestDriver and Main), which looks good,
however, the original classes contained a lot of information on what
each test does and how it
Hi Frank,
Overall these look fine. I would suggest adding a simple comment to describe
the tests that do not have one to give a basic intent of the test to make it
easier for someone to understand if they are new.
Best
Lance
On Mar 25, 2015, at 5:34 AM, Frank Yuan wrote:
> Hi, Joe and All
>
Hi, Joe and All
We are working on moving internal jaxp functional tests to open jdk repo.
This is the astro suite. Would you please review these test? Any comment
will be appreciated.
bug: https://bugs.openjdk.java.net/browse/JDK-8051560
webrev: http://cr.openjdk.java.net/~fyuan/8051560/
