Re: Review request for JDK-8078596: jaxp tests failed in modular jdk due to internal class access

2015-05-15 Thread huizhe wang
Hi Frank, The patch looks good. I'll check it in later today. Thanks, Joe On 5/15/2015 8:35 AM, Lance Andersen wrote: Hi Frank, Seems OK Best Lance On May 15, 2015, at 5:48 AM, Frank Yuan > wrote: Hi, Joe and All This is a test bug on 9-repo-jigsaw, jaxp t

Re: Review request for JDK-8078596: jaxp tests failed in modular jdk due to internal class access

2015-05-15 Thread Lance Andersen
Hi Frank, Seems OK Best Lance On May 15, 2015, at 5:48 AM, Frank Yuan wrote: > Hi, Joe and All > > > > This is a test bug on 9-repo-jigsaw, jaxp tests failed due to internal class > access. > > > > To fix this bug, I made the following changes: > > 1. moved the tests which test interna

Review request for JDK-8078596: jaxp tests failed in modular jdk due to internal class access

2015-05-15 Thread Frank Yuan
Hi, Joe and All This is a test bug on 9-repo-jigsaw, jaxp tests failed due to internal class access. To fix this bug, I made the following changes: 1. moved the tests which test internal APIs to separate directory and added @modules for them 2. for other tests which don't intend to test i