Re: Review request for JDK-8080266: Failed to create CharInfo due to ResourceBundle update for modules

2015-06-25 Thread Daniel Fuchs
Hi Frank, I could push it for you. -- daniel On 6/25/15 5:05 AM, Frank Yuan wrote: So, would you like to push the code for me? Best Regards Frank -Original Message- From: huizhe wang [mailto:huizhe.w...@oracle.com] Sent: Thursday, June 25, 2015 12:57 AM To: Daniel Fuchs Cc: Frank

RE: Review request for JDK-8080266: Failed to create CharInfo due to ResourceBundle update for modules

2015-06-25 Thread Frank Yuan
Alright, thanks a lot! :) Best Regards Frank -Original Message- From: Daniel Fuchs [mailto:daniel.fu...@oracle.com] Sent: Thursday, June 25, 2015 2:34 PM To: Frank Yuan; 'huizhe wang' Cc: 'core-libs-dev'; 'Lance Andersen'; 'jibing chen'; 'Gustavo Galimberti';

Review request for JDK-8080266: Failed to create CharInfo due to ResourceBundle update for modules

2015-06-24 Thread Frank Yuan
Hi, Would you like to have a review for bug https://bugs.openjdk.java.net/browse/JDK-8080266? This bug is caused by jigsaw change, the context class loader can't load internal resource which is in a named module any more. To fix it, LSSerializerImpl shall invoke

Re: Review request for JDK-8080266: Failed to create CharInfo due to ResourceBundle update for modules

2015-06-24 Thread Daniel Fuchs
Hi Frank, The proposed changes look good to me. best regards, -- daniel On 24/06/15 09:58, Frank Yuan wrote: Hi, Would you like to have a review for bug https://bugs.openjdk.java.net/browse/JDK-8080266? This bug is caused by jigsaw change, the context class loader can't load internal

RE: Review request for JDK-8080266: Failed to create CharInfo due to ResourceBundle update for modules

2015-06-24 Thread Frank Yuan
Hi Many thanks for your review! Best Regards Frank -Original Message- From: Daniel Fuchs [mailto:daniel.fu...@oracle.com] Sent: Wednesday, June 24, 2015 4:59 PM To: Frank Yuan; 'core-libs-dev'; 'Joe Wang' Cc: 'Lance Andersen'; 'jibing chen'; 'Gustavo Galimberti';

RE: Review request for JDK-8080266: Failed to create CharInfo due to ResourceBundle update for modules

2015-06-24 Thread Frank Yuan
So, would you like to push the code for me? Best Regards Frank -Original Message- From: huizhe wang [mailto:huizhe.w...@oracle.com] Sent: Thursday, June 25, 2015 12:57 AM To: Daniel Fuchs Cc: Frank Yuan; 'core-libs-dev'; 'Lance Andersen'; 'jibing chen'; 'Gustavo Galimberti';

Re: Review request for JDK-8080266: Failed to create CharInfo due to ResourceBundle update for modules

2015-06-24 Thread huizhe wang
+1. -Joe On 6/24/2015 1:58 AM, Daniel Fuchs wrote: Hi Frank, The proposed changes look good to me. best regards, -- daniel On 24/06/15 09:58, Frank Yuan wrote: Hi, Would you like to have a review for bug https://bugs.openjdk.java.net/browse/JDK-8080266? This bug is caused by jigsaw