Re: SelectableChannels and Process API

2015-07-28 Thread Roger Riggs
Hi Peter, Sorry to have taken so long to get back to this thread on SelectableChannels for process I/O. Working on the pipelines idea got me back to thinking about this proposal. One bit of spec/implementation to address is the state of the In/Out/Err streams of the process when using Redire

Re: SelectableChannels and Process API

2015-04-15 Thread Martin Buchholz
I have internalized the idea that finalization is a method of last resort. If there's a chance to free some OS resource by doing some work NOW, do it, and don't leave it for a finalizer to do later. On Wed, Apr 15, 2015 at 12:31 PM, Peter Levart wrote: > > > On 04/15/2015 07:59 PM, Martin Buchho

Re: SelectableChannels and Process API

2015-04-15 Thread Peter Levart
On 04/15/2015 07:59 PM, Martin Buchholz wrote: I was at least partly responsible for the pipe buffer cleanup code. Subprocess terminates, but may have written some data to the pipe buffer (typically 4k on Linux). Usually the pipe buffer is empty, but in case it's not, you don't want to lose

Re: SelectableChannels and Process API

2015-04-15 Thread Roger Riggs
Hi Martin, That sounds like finalization of the FileDescriptor, but perhaps a mechanism built on PhantomRef would be easier enough to maintain and can leave the data in the pipe. Roger On 4/15/2015 1:59 PM, Martin Buchholz wrote: I was at least partly responsible for the pipe buffer cleanup

Re: SelectableChannels and Process API

2015-04-15 Thread Roger Riggs
Hi Peter, I don't know the history behind the stream draining in ProcessImpl. I understood it to be a performance/scalability issue. Maybe Martin, Alan, or someone else can fill in the history. Roger On 4/15/2015 2:31 AM, Peter Levart wrote: Hi Roger, So I started new thread... On 04/14/2

Re: SelectableChannels and Process API

2015-04-15 Thread Martin Buchholz
I was at least partly responsible for the pipe buffer cleanup code. Subprocess terminates, but may have written some data to the pipe buffer (typically 4k on Linux). Usually the pipe buffer is empty, but in case it's not, you don't want to lose the straggler data, you want to drain it and close t

SelectableChannels and Process API

2015-04-14 Thread Peter Levart
Hi Roger, So I started new thread... On 04/14/2015 11:33 PM, Roger Riggs wrote: On 4/14/2015 11:47 AM, Peter Levart wrote: I have been thinking of another small Process API update. Some people find it odd how redirected in/out/err streams are exposed: http://blog.headius.com/2013/06/the-pa