Re: Simple RFR: 8203311 Clean up profile-includes.txt

2013-08-28 Thread Dawid Weiss
David, Is the fix for this committed anywhere? I've just tried building from scratch and I'm getting the same error. Dawid On Wed, Aug 21, 2013 at 10:55 AM, David Holmes david.hol...@oracle.com wrote: Fix on the way. This exposed another piece that was missing from the original change. But

Re: Simple RFR: 8203311 Clean up profile-includes.txt

2013-08-28 Thread Andreas Rieber
Hi Dawid, the fix is in jdk8tl already, just missed to come into jdk8. It's only a few lines. Andreas Here the changeset: Changeset: 3b8fed46b2a8 Author:dholmes Date: 2013-08-21 05:56 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/3b8fed46b2a8 8023460: OPENJDK build

Re: Simple RFR: 8203311 Clean up profile-includes.txt

2013-08-28 Thread Dawid Weiss
Thanks Andreas, I'll switch to that revision. On Wed, Aug 28, 2013 at 12:00 PM, Andreas Rieber rieberandr...@gmail.com wrote: Hi Dawid, the fix is in jdk8tl already, just missed to come into jdk8. It's only a few lines. Andreas Here the changeset: Changeset: 3b8fed46b2a8 Author:

Re: Simple RFR: 8203311 Clean up profile-includes.txt

2013-08-28 Thread David Holmes
Sorry about that. I thought the two fixes were travelling together else I would have taken steps to put them together. :( David On 28/08/2013 8:04 PM, Dawid Weiss wrote: Thanks Andreas, I'll switch to that revision. On Wed, Aug 28, 2013 at 12:00 PM, Andreas Rieber rieberandr...@gmail.com

Re: Simple RFR: 8203311 Clean up profile-includes.txt

2013-08-21 Thread Andreas Rieber
Hi David, your change causes build problems with ubuntu 12.04. Result is: make[2]: Entering directory `/usr/local/src/jdk8tl/jdk/makefiles' make[2]: *** No rule to make target `/usr/local/src/jdk8tl/build/linux-x86-normal-server-release/images/lib/jfr.jar', needed by `all'. Stop. make[2]:

Re: Simple RFR: 8203311 Clean up profile-includes.txt

2013-08-21 Thread David Holmes
Hi Andreas, On 21/08/2013 4:44 PM, Andreas Rieber wrote: Hi David, your change causes build problems with ubuntu 12.04. Result is: make[2]: Entering directory `/usr/local/src/jdk8tl/jdk/makefiles' make[2]: *** No rule to make target

Re: Simple RFR: 8203311 Clean up profile-includes.txt

2013-08-21 Thread Andreas Rieber
Hi David, On 21.08.13 09:53, David Holmes wrote: Hi Andreas, On 21/08/2013 4:44 PM, Andreas Rieber wrote: Hi David, your change causes build problems with ubuntu 12.04. Result is: make[2]: Entering directory `/usr/local/src/jdk8tl/jdk/makefiles' make[2]: *** No rule to make target

Re: Simple RFR: 8203311 Clean up profile-includes.txt

2013-08-21 Thread David Holmes
Fix on the way. This exposed another piece that was missing from the original change. But mea culpa for not doing an OPENJDK build. Sorry about that. Thanks, David On 21/08/2013 6:31 PM, Andreas Rieber wrote: Hi David, On 21.08.13 09:53, David Holmes wrote: Hi Andreas, On 21/08/2013 4:44

Re: Simple RFR: 8203311 Clean up profile-includes.txt

2013-08-20 Thread Alan Bateman
On 20/08/2013 00:33, David Holmes wrote: http://cr.openjdk.java.net/~dholmes/8023311/webrev/ Patch inlined below This is a trivial cleanup following on from an earlier change under 8017570. JFR was moved from profile compact3 to the full JRE but not all the variables in profile-includes.txt

Re: Simple RFR: 8203311 Clean up profile-includes.txt

2013-08-20 Thread David Holmes
On 20/08/2013 5:02 PM, Alan Bateman wrote: On 20/08/2013 00:33, David Holmes wrote: http://cr.openjdk.java.net/~dholmes/8023311/webrev/ Patch inlined below This is a trivial cleanup following on from an earlier change under 8017570. JFR was moved from profile compact3 to the full JRE but not

Simple RFR: 8203311 Clean up profile-includes.txt

2013-08-19 Thread David Holmes
http://cr.openjdk.java.net/~dholmes/8023311/webrev/ Patch inlined below This is a trivial cleanup following on from an earlier change under 8017570. JFR was moved from profile compact3 to the full JRE but not all the variables in profile-includes.txt were updated as needed. jfr.jar needed to