Re: Trivial RFR: 8026378: TEST_BUG: Clean up TEST.groups

2013-10-15 Thread David Holmes
Hi Mandy, On 15/10/2013 3:34 PM, Mandy Chung wrote: On 10/14/2013 10:02 PM, David Holmes wrote: http://cr.openjdk.java.net/~dholmes/8026378/webrev/ Looks okay with one question: [..] java/util/Collection/ListDefaults.java renamed to java/util/List/ListDefaults.java I skimmed on this

Re: Trivial RFR: 8026378: TEST_BUG: Clean up TEST.groups

2013-10-15 Thread Mandy Chung
On 10/14/2013 11:03 PM, David Holmes wrote: It uses testng which in turn requires compact2 because its use of sax/xml Oh that's right. I missed that is a TestNG test. thanks Mandy

Re: Trivial RFR: 8026378: TEST_BUG: Clean up TEST.groups

2013-10-15 Thread Alan Bateman
On 15/10/2013 07:03, David Holmes wrote: It uses testng which in turn requires compact2 because its use of sax/xml Right, we need to figure out a solution for that as more and more TestNG tests are added. Anyway, the changes in the webrev look okay to me too. I suspect that

Re: Trivial RFR: 8026378: TEST_BUG: Clean up TEST.groups

2013-10-15 Thread Mike Duigou
Thanks for this cleanup. Looks fine to me. It is disappointing to see some of the tests disabled for compact1 or compact2 because they use unrelated functionality. Is any effort planned to eliminate unnecessary dependencies? Mike On Oct 14 2013, at 22:02 , David Holmes wrote:

Re: Trivial RFR: 8026378: TEST_BUG: Clean up TEST.groups

2013-10-15 Thread David Holmes
An additional fix is needed due to a very recent rename :( java/net/HttpURLPermission/URLTest.java renamed to java/net/URLPermission/URLTest.java Updated webrev: http://cr.openjdk.java.net/~dholmes/8026378/webrev.v2/ On 16/10/2013 2:19 AM, Mike Duigou wrote: Thanks for this cleanup. Looks

Re: Trivial RFR: 8026378: TEST_BUG: Clean up TEST.groups

2013-10-15 Thread Mike Duigou
The additional change looks fine. On Oct 15 2013, at 16:14 , David Holmes david.hol...@oracle.com wrote: An additional fix is needed due to a very recent rename :( java/net/HttpURLPermission/URLTest.java renamed to java/net/URLPermission/URLTest.java Updated webrev:

Re: Trivial RFR: 8026378: TEST_BUG: Clean up TEST.groups

2013-10-15 Thread David Holmes
On 16/10/2013 9:19 AM, Mike Duigou wrote: The additional change looks fine. Thanks. On Oct 15 2013, at 16:14 , David Holmes david.hol...@oracle.com wrote: An additional fix is needed due to a very recent rename :( java/net/HttpURLPermission/URLTest.java renamed to

Re: Trivial RFR: 8026378: TEST_BUG: Clean up TEST.groups

2013-10-15 Thread Oracle
On Oct 16, 2013, at 7:14 AM, David Holmes david.hol...@oracle.com wrote: An additional fix is needed due to a very recent rename :( java/net/HttpURLPermission/URLTest.java renamed to java/net/URLPermission/URLTest.java Updated webrev:

Trivial RFR: 8026378: TEST_BUG: Clean up TEST.groups

2013-10-14 Thread David Holmes
http://cr.openjdk.java.net/~dholmes/8026378/webrev/ Trivial cleanup: Non-existent java/util/SummaryStatistics deleted from group jdk_stream Non-existent com/oracle/security deleted from jdk_security3 java/util/jar/Manifest/CreateManifest.java - moved from needs_jdk to needs_jre

Re: Trivial RFR: 8026378: TEST_BUG: Clean up TEST.groups

2013-10-14 Thread David Holmes
Correction ... On 15/10/2013 3:02 PM, David Holmes wrote: http://cr.openjdk.java.net/~dholmes/8026378/webrev/ Trivial cleanup: Non-existent java/util/SummaryStatistics deleted from group jdk_stream Non-existent com/oracle/security deleted from jdk_security3

Re: Trivial RFR: 8026378: TEST_BUG: Clean up TEST.groups

2013-10-14 Thread Mandy Chung
On 10/14/2013 10:02 PM, David Holmes wrote: http://cr.openjdk.java.net/~dholmes/8026378/webrev/ Looks okay with one question: [..] java/util/Collection/ListDefaults.java renamed to java/util/List/ListDefaults.java I skimmed on this test and it's not obvious to me - what compact2 API