Re: Why static_jli for java/javaw on Windows?

2018-09-14 Thread Magnus Ihse Bursie
-Original Message- From: Magnus Ihse Bursie Sent: den 14 september 2018 09:22 To: Erik Joelsson ; Alan Bateman ; core-libs-dev@openjdk.java.net Cc: build-dev Subject: Re: Why static_jli for java/javaw on Windows? On 2018-09-14 01:17, Erik Joelsson wrote: I checked and the copying

RE: Why static_jli for java/javaw on Windows?

2018-09-14 Thread Markus Gronlund
-Original Message- From: Magnus Ihse Bursie Sent: den 14 september 2018 09:22 To: Erik Joelsson ; Alan Bateman ; core-libs-dev@openjdk.java.net Cc: build-dev Subject: Re: Why static_jli for java/javaw on Windows? On 2018-09-14 01:17, Erik Joelsson wrote: > I checked and the copy

Re: Why static_jli for java/javaw on Windows?

2018-09-14 Thread Magnus Ihse Bursie
On 2018-09-14 01:17, Erik Joelsson wrote: I checked and the copying of java.exe was done in the now legacy jre installer, so from what I can tell, there is no longer a need for static linking. Sounds good. I agree with your reasoning, it seems the main concern was the copy to the system

Re: Why static_jli for java/javaw on Windows?

2018-09-13 Thread Erik Joelsson
I checked and the copying of java.exe was done in the now legacy jre installer, so from what I can tell, there is no longer a need for static linking. /Erik On 2018-09-13 09:14, Erik Joelsson wrote: Hello, Reading that bug, it seems the problem is when the installer copies java.exe into

Re: Why static_jli for java/javaw on Windows?

2018-09-13 Thread Erik Joelsson
Hello, Reading that bug, it seems the problem is when the installer copies java.exe into the Windows system directory. In that case, it may not have access to the msvcr re-distributables. I will try to find out if our installers are still doing this. /Erik On 2018-09-13 06:32, Alan

Re: Why static_jli for java/javaw on Windows?

2018-09-13 Thread Alan Bateman
On 13/09/2018 14:07, Magnus Ihse Bursie wrote: : Apparently, someone was trying to get rid of dll dependencies from java.exe. Why that would be desirable it does not say. Neither why this should not apply to all other launchers. (Perhaps there were not that many in these days?) Do

Why static_jli for java/javaw on Windows?

2018-09-13 Thread Magnus Ihse Bursie
On Windows, we compile two versions of libjli, one normal dynamic dll, and one static library *). Then when we create our launchers, we link with the normal, dynamic libjli for all launchers, except java.exe and javaw.exe, which are linked with the static library. The build system needs to do