Re: hg: jdk7/tl/jdk: 6880672: Replace quicksort in java.util.Arrays with dual-pivot implementation

2009-10-30 Thread Alan Bateman
Jonathan Gibbons wrote: Alan, Can I suggest you do a full build of JDK on JPRT with SKIP_BUILD_CYCLE=false to test this fix? -- Jon I've done that and all is well. I should say that the original changes did go through JPRT to check the build and ensure the java/util tests ran on all

Re: hg: jdk7/tl/jdk: 6880672: Replace quicksort in java.util.Arrays with dual-pivot implementation

2009-10-29 Thread Jonathan Gibbons
alan.bate...@sun.com wrote: Changeset: b05abb410c52 Author:alanb Date: 2009-10-29 11:18 + URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/b05abb410c52 6880672: Replace quicksort in java.util.Arrays with dual-pivot implementation Reviewed-by: jjb Contributed-by:

Re: hg: jdk7/tl/jdk: 6880672: Replace quicksort in java.util.Arrays with dual-pivot implementation

2009-10-29 Thread Alan Bateman
Jonathan Gibbons wrote: : Alan, My hudson falls over with a stack overflow at DualPivotQuicksort.java:477 when doing a full build (SKIP_BOOT_CYCLE=false) at java.util.DualPivotQuicksort.dualPivotQuicksort(DualPivotQuicksort.java:477) at

Re: hg: jdk7/tl/jdk: 6880672: Replace quicksort in java.util.Arrays with dual-pivot implementation

2009-10-29 Thread Joshua Bloch
My review of this patch: looks good to me. Josh On Thu, Oct 29, 2009 at 4:02 PM, Alan Bateman alan.bate...@sun.com wrote: Jonathan Gibbons wrote: : Alan, My hudson falls over with a stack overflow at DualPivotQuicksort.java:477 when doing a full build (SKIP_BOOT_CYCLE=false)