Re: hg: jdk8/tl/jdk: 7126277: Alternative String hashing implementation

2012-06-04 Thread Ulf Zibis
Hi Mike, Am 31.05.2012 07:19, schrieb mike.dui...@oracle.com: Changeset: 43bd5ee0205e Author:mduigou Date: 2012-05-30 22:18 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/43bd5ee0205e 7126277: Alternative String hashing implementation Summary: ... when the capacity of the

Re: hg: jdk8/tl/jdk: 7126277: Alternative String hashing implementation

2012-05-31 Thread Doug Lea
On 05/31/12 12:58, Mike Duigou wrote: So couldn't method hash(Object) be moved to AbstractMap? The differences in the avalanche (XOR scrambling) preclude this. It could be decided for Java 8 to use a consistent scrambling implementation. I would want to hear from Doug Lea whether he thinks this

Re: hg: jdk8/tl/jdk: 7126277: Alternative String hashing implementation

2012-05-31 Thread Mike Duigou
On May 31 2012, at 01:40 , Ulf Zibis wrote: > Hi Mike, > > some more questions: > > public class Hashmap { > +int hash(Object k) { > +int h = hashSeed; > +if (k instanceof String) { > +return ((String) k).hash32(); > +} else { > +h ^= k.hashCode()

Re: hg: jdk8/tl/jdk: 7126277: Alternative String hashing implementation

2012-05-31 Thread Ulf Zibis
Hi Mike, some more questions: public class Hashmap { +int hash(Object k) { +int h = hashSeed; +if (k instanceof String) { +return ((String) k).hash32(); +} else { +h ^= k.hashCode(); +} + +// This function ensures that hashCodes tha

hg: jdk8/tl/jdk: 7126277: Alternative String hashing implementation

2012-05-30 Thread mike . duigou
Changeset: 43bd5ee0205e Author:mduigou Date: 2012-05-30 22:18 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/43bd5ee0205e 7126277: Alternative String hashing implementation Summary: All of the hashing based Map implementations: HashMap, Hashtable, LinkedHashMap, WeakHashMap