Re: performance updates to jar and zip

2011-11-02 Thread Xueming Shen
On 10/31/2011 5:11 PM, Mike Skells wrote: (2) Iti is true that this is not a performance gain by code improvement, but it is a performnce gain by specification. The same arguement applies to allowing a Zip Compression of 1 rather than the default. As for the spec, all I have seen is that it

Re: performance updates to jar and zip

2011-10-31 Thread Xueming Shen
On 10/31/2011 5:11 PM, Mike Skells wrote: Hi Sherman, (1) Are the number here with writing the LOC in the background thread, in not I don't understand the comment The writeLOC in the base code version is very slow. each int written is written as 4 seperate bytes, each of which takes out lock

Re: performance updates to jar and zip

2011-10-31 Thread Mike Skells
o: Mike Skells >Cc: "core-libs-dev@openjdk.java.net" >Sent: Monday, 31 October 2011, 21:23 >Subject: Re: performance updates to jar and zip > > > >Hi Mike, > >(1) While it's not a "significant benefit" :-)  obviously it helps the through put to

Re: performance updates to jar and zip

2011-10-31 Thread Xueming Shen
ink that any of the API would return ../ Is it only on Z3 that this error occurs? I will install a Java8 with the patch, but it will be at the start of next week regards Mike ------------------------ *From:* Xueming Shen *To:* core-libs-dev@openjdk.java.net *Sent:* Thursday, 27 October 2011, 0:19

Re: performance updates to jar and zip

2011-10-27 Thread Mike Skells
be at the start of next week regards Mike > >From: Xueming Shen >To: core-libs-dev@openjdk.java.net >Sent: Thursday, 27 October 2011, 0:19 >Subject: Re: performance updates to jar and zip > >Hi Mark > >It appears the patch you provided

Re: performance updates to jar and zip

2011-10-27 Thread Xueming Shen
On 10/27/2011 06:07 AM, Alan Bateman wrote: On 27/10/2011 00:19, Xueming Shen wrote: : Here are the "surprising" results. "nio" is the walkFileTree, "io" is the File.list() "io2" is the File.listFiles(). The nio's File.walkFileTree is 15 times faster than the "traditional" recursion+File.

Re: performance updates to jar and zip

2011-10-27 Thread Alan Bateman
On 27/10/2011 00:19, Xueming Shen wrote: : Here are the "surprising" results. "nio" is the walkFileTree, "io" is the File.list() "io2" is the File.listFiles(). The nio's File.walkFileTree is 15 times faster than the "traditional" recursion+File.list(). wow! At least for your testing on L

Re: performance updates to jar and zip

2011-10-26 Thread Xueming Shen
Hi Mark It appears the patch you provided throws unexpected exception (attached at the end of my email) when I tried it out on the latest JDK8 repository. Since I only did a quick scan of your patch, I'm not sure what went wrong here. This patch includes lots of stuff that obviously you ar

Re: performance updates to jar and zip

2011-10-21 Thread Mike Skells
>Subject: Re: performance updates to jar and zip > >Hi Mike, > >It appears the patch failed to patch the ZipCoder for my JDK8 workspace (I did >not look into >details, guess the patch is against and "old" version, if you can just send me >the updated >ZipCoder f

Re: performance updates to jar and zip

2011-10-20 Thread Xueming Shen
Hi Mike, It appears the patch failed to patch the ZipCoder for my JDK8 workspace (I did not look into details, guess the patch is against and "old" version, if you can just send me the updated ZipCoder file, I can add it into the workspace directly) I pull the rest change into a webrev at h

performance updates to jar and zip

2011-10-20 Thread Mike Skells
Hi All, I have some performance updates for the jar tool and for the Zip/Jar writing components, including some code to allow parallel writing of Jar and ZIP files (in java.util)  This work is not finished as yet but I am looking to see if anyone has any views as to the shape this should move i