> Michael - the Contributed-by line is usually the individual's name (+ mail
> address) or a list of names (and their mail addresses). I think Stuart is
> suggesting that this would be better than "London Java Community".
Okay, no problem:
Contributed-by: Prasannaa , Martijn Verburg
, Goerge_Albr
Hi,
> scan of the webrev. There are still a couple of raw type warnings in JarFile
> and several more in other classes in these packages so it's possible you
> don't have everything (I wasn't following that thread closely on jdk8-dev).
Question on a rawtypes fix. In one case there is method defi
>> I looked at the updated patch and it looks fine to me. There are other
>> classes
>> in j.u.jar and j.u.logging that also have warnings but fixing the warnings
I only submitted the ones that we managed to work on during the hack
day. If the team is happy to continue accepting fresh patches for
> There is a rawtypes warning on the "new ArrayList()". I can put a
> specific type as the return value should match
> "jv.getManifestDigests()", which is public so shouldn't be changed. I
Sorry that should read "I can't put a specific type...
Hi,
Attached is the latest LJC warnings patch. I've merged all of the
changes into a single patch. The one I'm unsure of the comments on
the @SuppressWarnings("deprecation") in the ZipEntry.java. I've been
fairly terse and just mentioned that it's using the date
methods/constructor.
Regards,
M
Hi Stuart,
Thanks for picking up the review.
> - java/util/jar/JarFile.java
> - java/util/jar/Manifest.java [patch4]
> - java/util/logging/LogManager.java [patch2]
> - java/util/prefs/Preferences.java
> - java/util/prefs/XmlSupport.java
> - java/util/zip/ZipEntry.java [patch2]
>
> Did I get
On 12/7/11 2:34 AM, Michael Barker wrote:
Michael - the Contributed-by line is usually the individual's name (+ mail
address) or a list of names (and their mail addresses). I think Stuart is
suggesting that this would be better than "London Java Community".
Okay, no problem:
Contributed-by: Pr
On 7/12/2011 9:12 PM, Martijn Verburg wrote:
Hi all,
Question on contributions, I assume that as the patch is coming from Mike,
his OCA covers the rest of us?
These patches are simple enough that OCA is not necessary - any
Participant can submit simple patches [1]
David
--
[1] http://o
Hi all,
Question on contributions, I assume that as the patch is coming from Mike,
his OCA covers the rest of us?
Cheers,
Martijn
On Wednesday, 7 December 2011, Alan Bateman wrote:
> On 07/12/2011 08:43, Michael Barker wrote:
>>
>> :
>>>
>>> 7117249: fix warnings in java.util.jar, .logging, .p
On 07/12/2011 08:43, Michael Barker wrote:
:
7117249: fix warnings in java.util.jar, .logging, .prefs, .zip
Reviewed-by: alanb, dholmes, forax, sherman, smarks
Contributed-by: London Java Community and Michael Barker
Since the changeset comment is baked for all eternity, :-) I wanted to
On 12/6/11 12:46 PM, Alan Bateman wrote:
On 06/12/2011 18:46, Michael Barker wrote:
Attached is the latest LJC warnings patch. I've merged all of the
changes into a single patch. The one I'm unsure of the comments on
the @SuppressWarnings("deprecation") in the ZipEntry.java. I've been
fairly ter
On 06/12/2011 18:46, Michael Barker wrote:
Hi,
Attached is the latest LJC warnings patch. I've merged all of the
changes into a single patch. The one I'm unsure of the comments on
the @SuppressWarnings("deprecation") in the ZipEntry.java. I've been
fairly terse and just mentioned that it's us
On 04/12/2011 08:56, Michael Barker wrote:
Hi,
scan of the webrev. There are still a couple of raw type warnings in JarFile
and several more in other classes in these packages so it's possible you
don't have everything (I wasn't following that thread closely on jdk8-dev).
Question on a rawtype
On 12/3/11 2:32 PM, Michael Barker wrote:
Mike, if you end up needing to update this patch further, it might be
easiest if you just sent all the changes in a single patch file, i.e. the
output of 'hg diff'. I can then apply it to the tip and generate a webrev
quite easily.
No problem. I'll dro
On 03/12/2011 20:59, Stuart Marks wrote:
[bcc to jdk8-dev; subsequent reviews/comments should go to core-libs-dev]
Hi Mike, all,
I've collected all the patches together, filed bug 7117249 to cover
them, and have started this new review thread on core-libs-dev for it.
I've also posted a webrev
[bcc to jdk8-dev; subsequent reviews/comments should go to core-libs-dev]
Hi Mike, all,
I've collected all the patches together, filed bug 7117249 to cover them, and
have started this new review thread on core-libs-dev for it. I've also posted a
webrev for the collected patches:
http://cr.op
16 matches
Mail list logo
