Re: review request: 8035782 : sun/launcher/LauncherHelper$FXHelper loaded unnecessarily

2014-04-29 Thread Neil Toda
Thanks Kumar. Will check these. I have FXLauncherTest.java open right now as I type. I started looking at it yesterday. Good that I am looking at the right test case. Good organization. I might also have to add a non FX jar file to test.. unless I've missed that. -neil On 4/29/2014

Re: review request: 8035782 : sun/launcher/LauncherHelper$FXHelper loaded unnecessarily

2014-04-29 Thread Kumar Srinivasan
On 4/29/2014 8:50 AM, Neil Toda wrote: Thanks Kumar. Will check these. I have FXLauncherTest.java open right now as I type. I started looking at it yesterday. Good that I am looking at the right test case. Good organization. I might also have to add a non FX jar file to test.. unless

Re: review request: 8035782 : sun/launcher/LauncherHelper$FXHelper loaded unnecessarily

2014-04-29 Thread Neil Toda
Great. Thanks. On 4/29/2014 9:45 AM, Kumar Srinivasan wrote: On 4/29/2014 8:50 AM, Neil Toda wrote: Thanks Kumar. Will check these. I have FXLauncherTest.java open right now as I type. I started looking at it yesterday. Good that I am looking at the right test case. Good

Re: review request: 8035782 : sun/launcher/LauncherHelper$FXHelper loaded unnecessarily

2014-04-25 Thread Kevin Rushforth
The code changes looks fine to me. Also, I ran all JavaFX unit tests with no problems (at least none relating to launching). -- Kevin Neil Toda wrote: Webrev http://cr.openjdk.java.net/~ntoda/8035782/ for bug https://bugs.openjdk.java.net/browse/JDK-8035782 The file :

Re: review request: 8035782 : sun/launcher/LauncherHelper$FXHelper loaded unnecessarily

2014-04-25 Thread Neil Toda
Thanks Kevin. -neil On 4/25/2014 8:22 AM, Kevin Rushforth wrote: The code changes looks fine to me. Also, I ran all JavaFX unit tests with no problems (at least none relating to launching). -- Kevin Neil Toda wrote: Webrev http://cr.openjdk.java.net/~ntoda/8035782/ for bug

review request: 8035782 : sun/launcher/LauncherHelper$FXHelper loaded unnecessarily

2014-04-21 Thread Neil Toda
Webrev http://cr.openjdk.java.net/~ntoda/8035782/ for bug https://bugs.openjdk.java.net/browse/JDK-8035782 The file : ./jdk/src/share/classes/sun/launcher/LauncherHelper.java has been modified so that the inner class FXHelper is not loaded unnecessarily. FXHelper, which is needed to