Re: LinkedList facelift

2009-11-04 Thread Rémi Forax
Le 03/11/2009 20:32, Martin Buchholz a écrit : On Tue, Nov 3, 2009 at 01:06, Rémi Forax > wrote: Hi Martin, Your patch can break backward compat. add(E) now delegates to a public method (an overridable one) (addLast). So If I have a class that inheri

Re: LinkedList facelift

2009-11-04 Thread Martin Buchholz
On Wed, Nov 4, 2009 at 06:18, Rémi Forax wrote: > Good for me if addFirst() calls linkFirst() and > addLast() calls linkLast(). > > Sigh. Of course, that's what I intended to do. Done. Also, renamed addBefore to linkBefore and moved near to the other linkXXX methods. Webrev regenerated. Tha

Optimize Formatter.parse (including String.printf)

2009-11-04 Thread Martin Buchholz
Hi Sherman, I'd like you to do a code review. http://cr.openjdk.java.net/~martin/webrevs/openjdk7/Formatter.parse/ Synopsis: Optimize Formatter.parse (including String.printf) Description: Formatter is not as efficient as it could be. Here's a low-hanging fruit optimization that creates fewer ob

Re: Optimize Formatter.parse (including String.printf)

2009-11-04 Thread Xueming Shen
I will take a look. The bugid# is 6898220. sherman Martin Buchholz wrote: Hi Sherman, I'd like you to do a code review. http://cr.openjdk.java.net/~martin/webrevs/openjdk7/Formatter.parse/ Synopsis: Optimize Formatte

Re: LinkedList facelift

2009-11-04 Thread Rémi Forax
Le 04/11/2009 19:25, Martin Buchholz a écrit : On Wed, Nov 4, 2009 at 06:18, Rémi Forax > wrote: Good for me if addFirst() calls linkFirst() and addLast() calls linkLast(). Sigh. Of course, that's what I intended to do. Done. Also, renamed addBefore to l

hg: jdk7/tl/jaxp: 6898251: Add ALT_DROPS_DIR feature to jaxp/jaxws

2009-11-04 Thread ahughes
Changeset: 26b97fd0e595 Author:andrew Date: 2009-11-05 00:00 + URL: http://hg.openjdk.java.net/jdk7/tl/jaxp/rev/26b97fd0e595 6898251: Add ALT_DROPS_DIR feature to jaxp/jaxws Summary: Allow the directory for downloaded drops to be set using ALT_DROPS_DIR Reviewed-by: ohair, jjg

hg: jdk7/tl/jaxws: 6898251: Add ALT_DROPS_DIR feature to jaxp/jaxws

2009-11-04 Thread ahughes
Changeset: 600bc3d048be Author:andrew Date: 2009-11-05 00:02 + URL: http://hg.openjdk.java.net/jdk7/tl/jaxws/rev/600bc3d048be 6898251: Add ALT_DROPS_DIR feature to jaxp/jaxws Summary: Allowthe directory for downloaded drops to beset using ALT_DROPS_DIR Reviewed-by: ohair, jjg !