Hello,
The Dual-Pivot Quicksort source code contains several
double spaces and it would be nice to remove them, the
changes in DualPivotQuicksort class are pretty trivial:
1. ... is empty and the call is ...
^^
2. ... // (a[k] > pivot1) - Move a[k] to right part ...
DOH! Yeah that one looks better... ;^)
Thought they looked the same before.
-kto
On 2/25/10 11:08 AM, Alan Bateman wrote:
Kelly O'Hair wrote:
Looks fine to me.
-kto
Thanks Kelly and also to Joe for pointing out that I botched the link to
the second one - here is the right webrev:
http://cr.
Xueming Shen wrote:
http://cr.openjdk.java.net/~sherman/6929479/webrev/
This is a rfe to add a system property sun.zip.disableMmap to enable
the end user to disable the mmap usage in
Sun's java.util.zip.ZipFile implementaiton (for Solaris and Linux
platforms).
Application uses java.util.zip
Changeset: 85242c273d31
Author:darcy
Date: 2010-02-25 11:04 -0800
URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/85242c273d31
6929645: Address various findbugs warnings in langtools
Reviewed-by: jjg
! src/share/classes/com/sun/tools/apt/comp/Apt.java
!
src/share/classes/com
Looks fine to me.
-kto
On 2/25/10 9:51 AM, Alan Bateman wrote:
There are two fixes in Sun's proprietary jdk6 updates that should also
be fixed in OpenJDK.
The first one is that the File.getXXXSpace methods use statvfs instead
of statvfs64 and so fail on 32-bit Solaris and Linux with very larg
Kelly O'Hair wrote:
Looks fine to me.
-kto
Thanks Kelly and also to Joe for pointing out that I botched the link to
the second one - here is the right webrev:
http://cr.openjdk.java.net/~alanb/6921374/webrev/
-Alan
http://cr.openjdk.java.net/~sherman/6929479/webrev/
This is a rfe to add a system property sun.zip.disableMmap to enable the
end user to disable the mmap usage in
Sun's java.util.zip.ZipFile implementaiton (for Solaris and Linux
platforms).
Application uses java.util.zip.ZipFile might experi
Alan Bateman wrote:
Xueming Shen wrote:
http://cr.openjdk.java.net/~sherman/6929479/webrev/
This is a rfe to add a system property sun.zip.disableMmap to enable
the end user to disable the mmap usage in
Sun's java.util.zip.ZipFile implementaiton (for Solaris and Linux
platforms).
Applicati
There are two fixes in Sun's proprietary jdk6 updates that should also
be fixed in OpenJDK.
The first one is that the File.getXXXSpace methods use statvfs instead
of statvfs64 and so fail on 32-bit Solaris and Linux with very large
file systems. The webrev is here:
http://cr.openjdk.java.n
Xueming Shen wrote:
:
The webrev has been updated to use "sun.zip.disableMmapping", I guess
you meant "sun.zip.disableMmapping", right?
It's hard to find a good name. I was suggesting disableMapping (no
double m) but disableMemoryMapping could work too.
-Alan.
Going forward, should we be using sun or oracle in the property names?
-lance
Alan Bateman wrote:
Xueming Shen wrote:
:
The webrev has been updated to use "sun.zip.disableMmapping", I guess
you meant "sun.zip.disableMmapping", right?
It's hard to find a good name. I was suggesting disableMapp
On 25 February 2010 18:19, Kelly O'Hair wrote:
> Looks fine to me.
>
> -kto
>
> On 2/25/10 9:51 AM, Alan Bateman wrote:
>>
>> There are two fixes in Sun's proprietary jdk6 updates that should also
>> be fixed in OpenJDK.
>>
>> The first one is that the File.getXXXSpace methods use statvfs instead
Why don't you use the faster local copy of count for the junction like:
if (h == 0&& len> 0) {
?
-Ulf
Am 25.02.2010 20:08, schrieb Alan Bateman:
Kelly O'Hair wrote:
Looks fine to me.
-kto
Thanks Kelly and also to Joe for pointing out that I botched the link
to the second one - here
Yup. My eyes must be tired, I didn't see that. :^(
-kto
On 2/25/10 12:17 PM, Ulf Zibis wrote:
Why don't you use the faster local copy of count for the junction like:
if (h == 0&& len> 0) {
?
-Ulf
Am 25.02.2010 20:08, schrieb Alan Bateman:
Kelly O'Hair wrote:
Looks fine to me.
-kto
Th
Changeset: dbcba45123cd
Author:jjg
Date: 2010-02-25 12:26 -0800
URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/dbcba45123cd
6929544: langtools source code uses statics qualified by instance variables
Reviewed-by: darcy
! make/build.properties
! src/share/classes/com/sun/tool
Changeset: af75fd6155de
Author:jjg
Date: 2010-02-25 13:32 -0800
URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/af75fd6155de
6893943: exit code from javah with no args is 0
Reviewed-by: darcy
! src/share/classes/com/sun/tools/javah/JavahTask.java
+ test/tools/javah/T6893943.j
Alan,
Shouldn't the loading of 'this.count' into 'len' be only performed if 'h' is
zero? Otherwise, when hash is not zero we perform a little unnecessary work
every time hashCode is called.
Jason
> Date: Thu, 25 Feb 2010 21:17:37 +0100
> From: ulf.zi...@gmx.de
> To: alan.bate...@sun.c
Kelly O'Hair wrote:
Yup. My eyes must be tired, I didn't see that. :^(
Too many repositories in the air at the same time. The webrev has been
refreshed. Thanks Ulf.
Andrew John Hughes wrote:
On 25 February 2010 18:19, Kelly O'Hair wrote:
Looks fine to me.
-kto
On 2/25/10 9:51 AM, Alan Bateman wrote:
There are two fixes in Sun's proprietary jdk6 updates that should also
be fixed in OpenJDK.
The first one is that the File.getXXXSpace methods use
Alan, Martin, Masayoshi and anyone interested, please help comment and
review.
Bugs/RFEs:
6911753: NSN wants to add Big5 HKSCS-2004 support
6902790: Converting/displaying HKSCS characters issue on Vista and Windows7
6218752: Update HKSCS and GB18030 converters for Unicode 4.1
Webrev:
http://cr.
20 matches
Mail list logo
