Changeset: 04cf82179fa7
Author:mcimadamore
Date: 2010-04-21 12:24 +0100
URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/04cf82179fa7
6730476: invalid "unchecked generic array" warning
Summary: Reifiable-ness of varargs element type should be checked after JLS3
15.12.2.8
Revie
I now have the second part of my planned improvements to
Linux process handling, and is now a serious proposal.
for Michael and others to review.
http://cr.openjdk.java.net/~martin/webrevs/openjdk7/UNIXProcess/
http://cr.openjdk.java.net/~martin/webrevs/openjdk7/UNIXProcess2/
This is a huge perfo
Martin,
In src/solaris/classes/java/lang/UNIXProcess.java.linux, are lines
177, 181, and 185 needed? If the assignment of these streams were in
the constructor, they could be final.
176 synchronized void processExited(int exitcode) {
177 stdout = this.stdout;
178 if (stdout
Thanks for the careful review.
On Wed, Apr 21, 2010 at 17:47, David Schlosnagle wrote:
> Martin,
>
> In src/solaris/classes/java/lang/UNIXProcess.java.linux, are lines
> 177, 181, and 185 needed? If the assignment of these streams were in
> the constructor, they could be final.
Fixed.
Yes, the
On Wed, Apr 21, 2010 at 9:14 PM, Martin Buchholz wrote:
> Thanks for the careful review.
No problem, I wanted test this patch out on OS X since the current
UNIXProcess.java.bsd is virtually identical to UNIXProcess.java.linux.
I slightly tweaked the ManyProcesses test to exec /usr/bin/true and
lo
.
Fixed. (do you have a tool to detect extra imports?)
There are a number of tools:
IntelliJ: Free community version
:http://download.jetbrains.com/idea/ideaIC-9.0.2.exe
PMD: http://pmd.sourceforge.net/rules/imports.html
NetBeans: http://netbeans.org/kb/67/java/editor-tips.html
etc...
Changeset: edde2f60415b
Author:weijun
Date: 2010-04-22 12:45 +0800
URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/edde2f60415b
6856069: PrincipalName.clone() does not invoke super.clone()
Reviewed-by: chegar
! src/share/classes/sun/security/krb5/PrincipalName.java
+ test/sun/secur
David,
On Wed, Apr 21, 2010 at 20:15, David Schlosnagle wrote:
> On Wed, Apr 21, 2010 at 9:14 PM, Martin Buchholz wrote:
> Running ManyProcesses with Apple's version of 1.6.0_17-b04-248,
> averages around 45 seconds and 4010 started threads.
> Running ManyProcesses with the bsd-port of OpenJDK7
