This seems like an improvement to me.
The only question is whether it's worth doing,
but you obviously think it is, and that's good
enough for me.
Martin
On Thu, May 6, 2010 at 22:29, Xueming Shen wrote:
> Martin,
>
> Do you have time to take a quick look on this one? If you agree the proposed
>
Changeset: a6928350e1f2
Author:chegar
Date: 2010-05-07 10:11 +0100
URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/a6928350e1f2
6947917: Error in basic authentication when user name and password are long
Reviewed-by: weijun
! src/share/classes/sun/net/www/protocol/http/BasicAuthent
Hi,
Wouldn't it better to use boolean flag instead of int index?
--
Dmytro Sheyko
PS
--- DualPivotQuicksortWithoutSentinel.javaFri May 07 10:40:14 2010
+++ DualPivotQuicksortWithoutSentinelA.javaFri May 07 11:54:51 2010
@@ -39,7 +39,7 @@
* @version 2010.04.30 m765.827.12i:5\7
Hello Dmytro,
I tried this case too, and the results are the same.
But to be sure, I will check your version again.
Thank you,
Vladimir
Dmytro Sheyko wrote:
Hi,
Wouldn't it better to use boolean flag instead of int index?
--
Dmytro Sheyko
PS
--- DualPivotQuicksortWithoutSentinel.javaFr
Hi David, Martin,
Thanks for filing the bug David, I'll just add a link to the email
thread in the archive for reference.
Just one minor observation while reviewing the changes. Is it necessary
for initFromPriorityQueue to call initFromCollection ( in the case where
you're given a PriorityQu
Hi Chris,
Chris Hegarty said the following on 05/07/10 19:55:
Hi David, Martin,
Thanks for filing the bug David, I'll just add a link to the email
thread in the archive for reference.
Thanks.
Just one minor observation while reviewing the changes. Is it necessary
for initFromPriorityQueue
On 07/05/2010 11:47, David Holmes wrote:
Hi Chris,
Chris Hegarty said the following on 05/07/10 19:55:
Hi David, Martin,
Thanks for filing the bug David, I'll just add a link to the email
thread in the archive for reference.
Thanks.
Just one minor observation while reviewing the changes. I
Hi Dmytro,
Your suggested variant is better than variant with fromIndex.
It works little bit faster than my original one: ~0.7% for
client and the same for server VM (my variant with boolean
flag uses opposite value, and it works slower than yours).
Now the ratio of times is:
new / jdk7: 0.88 f
Changeset: 4fba3512c566
Author:chegar
Date: 2010-05-07 16:11 +0100
URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/4fba3512c566
6946673: DatagramSocket.connect() documentation contradicts the implementation
Reviewed-by: alanb
! src/share/classes/java/net/DatagramSocket.java
On Fri, May 7, 2010 at 03:47, David Holmes wrote:
> Hi Chris,
>
> Chris Hegarty said the following on 05/07/10 19:55:
>>
>> Hi David, Martin,
>>
>> Thanks for filing the bug David, I'll just add a link to the email thread
>> in the archive for reference.
>
> Thanks.
>
>> Just one minor observation
10 matches
Mail list logo
