Hello,
Thank you for review, I'll check and run tests again with you changes.
Thank you,
Vladimir
Dmytro Sheyko wrote:
Hello,
More ideas.
1. We can use
Double.doubleToRawLongBits instead of Double.doubleToLongBits and
Float.floatToRawIntBits instead of Float.floatToIntBits.
No need to handle
Changeset: 43f83a2cf5b5
Author:sherman
Date: 2010-05-17 12:19 -0700
URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/43f83a2cf5b5
4813885: RFE: GZIPOutputStream should implement flush using Z_SYNC_FLUSH
Summary: Added new constructors to allow flush() work in Z_SYNC_FLUSH mode
Review
Martin,
It appears we should make the defensive copy in this case, as we usually
do in lib code.
http://cr.openjdk.java.net/~sherman/4853493/webrev
-Sherman
Sounds good!
Will consider too...
Mon, 17 May 2010 22:24:11 +0700 письмо от Dmytro Sheyko
:
> Hi,
>
> Regarding counting sort. We can check whether we should switch to counting
> sort only once in the beginning.
>
> > Date: Mon, 17 May 2010 17:30:37 +0400
> > From: iaroslav...@mail.ru
> > Sub
On Mon, May 17, 2010 at 13:33, Xueming Shen wrote:
> Martin,
>
> It appears we should make the defensive copy in this case, as we usually do
> in lib code.
Yeah, that does look necessary. Approved!
You could also keep the header code
inside the method thus:
private void writeHeader() throw
It appears the "inline" version makes the GZIPOutputStream.class about
140 byte smaller. And I would
guess it might be also faster. The webrev has been updated to go with
the "inline" version.
Thanks,
-Sherman
Martin Buchholz wrote:
On Mon, May 17, 2010 at 13:33, Xueming Shen wrote:
Ma
Looks good!
Martin
On Mon, May 17, 2010 at 15:59, Xueming Shen wrote:
>
> It appears the "inline" version makes the GZIPOutputStream.class about 140
> byte smaller. And I would
> guess it might be also faster. The webrev has been updated to go with the
> "inline" version.
>
> Thanks,
> -Sherman
Changeset: 1e0c3e864fb1
Author:sherman
Date: 2010-05-17 16:18 -0700
URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/1e0c3e864fb1
4853493: GZIPOutputStream passes a reference to a private array into an
untrusted method
Summary: create a new header byte array for each header writeout
