Code review request for 6935997 "Please add a nested throwable constructor to AssertionError"

2010-06-04 Thread Joe Darcy
Hello. Please review my fix for 6935997 "Please add a nested throwable constructor to AssertionError" http://cr.openjdk.java.net/~darcy/6935997.0/ Thanks, -Joe

Re: Code review request for 6935997 "Please add a nested throwable constructor to AssertionError"

2010-06-04 Thread Martin Buchholz
Looks good! Martin On Thu, Jun 3, 2010 at 23:58, Joe Darcy wrote: > Hello. > > Please review my fix for > > 6935997 "Please add a nested throwable constructor to AssertionError" > http://cr.openjdk.java.net/~darcy/6935997.0/ > > Thanks, > > -Joe >

Re: Code review request for 6935997 "Please add a nested throwable constructor to AssertionError"

2010-06-04 Thread Rémi Forax
Le 04/06/2010 09:13, Martin Buchholz a écrit : Looks good! Martin Ok for me too. Rémi On Thu, Jun 3, 2010 at 23:58, Joe Darcy wrote: Hello. Please review my fix for 6935997 "Please add a nested throwable constructor to AssertionError" http://cr.openjdk.java.net/~darcy/6935997.0/

Re: Code review request for 6935997 "Please add a nested throwable constructor to AssertionError"

2010-06-04 Thread Bruce Chapman
Is this a first step to fixing the compiler error where the JLS says the (2nd) expression in an assert statement is converted to String and a new AssertionError is constructed with that STRING as the argument, and that AssertionError is thrown? (my paraphrase) http://java.sun.com/docs/books/jls/t

Re: Code review request for 6935997 "Please add a nested throwable constructor to AssertionError"

2010-06-04 Thread David Holmes
Bruce Chapman said the following on 06/04/10 18:46: Is this a first step to fixing the compiler error where the JLS says the (2nd) expression in an assert statement is converted to String and a new AssertionError is constructed with that STRING as the argument, and that AssertionError is thrown?

hg: jdk7/tl/jdk: 6951366: kerberos login failure on win2008 with AD set to win2000 compat mode

2010-06-04 Thread weijun . wang
Changeset: ea8c57ec8409 Author:weijun Date: 2010-06-04 19:28 +0800 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/ea8c57ec8409 6951366: kerberos login failure on win2008 with AD set to win2000 compat mode Reviewed-by: valeriep, xuelei ! src/share/classes/sun/security/krb5/Credenti

Shouldn't HashSet/Map use Arrays.hashCode(x[]) ?

2010-06-04 Thread Ulf Zibis
Otherwise e.g. int[] as key for HashSet/Map doesn't make any sense. I use a class where the content of an int[] defines the uniqueness or there instances. Before I create a new instance, I have to check if there is just one for the same int[] content. Using the current HashSet/Map implementati

Re: Shouldn't HashSet/Map use Arrays.hashCode(x[]) ?

2010-06-04 Thread Martin Buchholz
Aside from the fact that it would be a hugely incompatible change to change the hashing/equality algorithm now, it is quite a religious argument about which is the Right Thing to do. Here's some religion/philosophy for you: http://home.pipeline.com/~hbaker1/ObjectIdentity.html There are some exis

Re: Shouldn't HashSet/Map use Arrays.hashCode(x[]) ?

2010-06-04 Thread Ulf Zibis
Am 04.06.2010 20:26, schrieb Martin Buchholz: Aside from the fact that it would be a hugely incompatible change to change the hashing/equality algorithm now, it is quite a religious argument about which is the Right Thing to do. In most cases we have freedom of religion as we have HashMap a

hg: jdk7/tl/langtools: 6958391: add vizant support to langtools build

2010-06-04 Thread jonathan . gibbons
Changeset: b7fc560217d3 Author:jjg Date: 2010-06-04 14:54 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/b7fc560217d3 6958391: add vizant support to langtools build Reviewed-by: mcimadamore ! make/build.properties ! make/build.xml

hg: jdk7/tl/langtools: 6958802: cleanup and doc langtools build.xml file

2010-06-04 Thread jonathan . gibbons
Changeset: d33b91f360fc Author:jjg Date: 2010-06-04 17:33 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/d33b91f360fc 6958802: cleanup and doc langtools build.xml file Reviewed-by: ohair ! make/build.properties ! make/build.xml

ArrayCopyMicroBenchmark.java

2010-06-04 Thread Martin Buchholz
Hi, I wrote an ArrayCopyMicroBenchmark years ago, that has found repeated use, despite being buried in a bug report. I'd like to commit it to the jdk repo. It differes only in minor touchups, like Oracle copyright, from the bug report. Chris and or David, please file a bug on my behalf. Thanks,

Re: ArrayCopyMicroBenchmark.java

2010-06-04 Thread Martin Buchholz
Oops, forgot to include the link. But it should come as no surprise to the readers of this list that the webrev can be found here: http://cr.openjdk.java.net/~martin/webrevs/openjdk7/ArrayCopyMicroBenchmark/ Martin On Fri, Jun 4, 2010 at 18:22, Martin Buchholz wrote: > Hi, > > I wrote an ArrayCo

Removing a layer of synchronization on Math.random

2010-06-04 Thread Martin Buchholz
Here's an optimization for Math.random() that appears to be safe, despite the double-check access: http://cr.openjdk.java.net/~martin/webrevs/openjdk7/Math.random/ David, if you agree, could you file a bug? Thanks, Martin