Re: PING: Re: Fix build failure with JAVAC_MAX_WARNINGS=true in sun/nio/cs

2010-06-12 Thread Andrew John Hughes
On 9 June 2010 18:22, Xueming Shen wrote: > Andrew John Hughes wrote: >> >> On 9 June 2010 07:55, Florian Weimer wrote: >> >>> >>> * Andrew John Hughes: >>> >>> On 7 June 2010 23:04, Xueming Shen wrote: > > Hi Andrew, > > 6959197: When building with JAVAC_MAX_WARNI

Re: PING: Re: Fix build failure with JAVAC_MAX_WARNINGS=true in sun/nio/cs

2010-06-12 Thread Xueming Shen
Andrew, Thanks for working on it. The change looks fine, except one final nit:-) EUC_JP_Open: #127 & #140 it appears encoderJ0208 is no longer needed. Please run those tests at sun/nio/cs before push, I don't really trust my own eyes these days:-) Sherman Andrew John Hughes wrote: