Re: Threads should not be Cloneable

2010-08-16 Thread Chris Hegarty
Thanks everyone for your very valuable feedback. From what I'm reading there doesn't seem to be a problem with defining Thread.clone to throw CloneNotSupportedException. OK, that's done. Now should it be final? It appears that there is very little value in making clone non-final. Yes, it wil

Re: Threads should not be Cloneable

2010-08-16 Thread Brian Goetz
Compatibility is not an end unto itself; IMO compatibility with broken programs is not something we should spend our effort maintaining. I'm +1 on this change, with final. On 8/16/2010 5:03 AM, Chris Hegarty wrote: Thanks everyone for your very valuable feedback. From what I'm reading there

hg: jdk7/tl/langtools: 2 new changesets

2010-08-16 Thread maurizio . cimadamore
Changeset: 27bae58329d5 Author:mcimadamore Date: 2010-08-16 14:56 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/27bae58329d5 6976649: javac does not enforce required annotation elements in arrays Summary: type annotation should take advantage of recursive annotation ch

Re: Threads should not be Cloneable

2010-08-16 Thread Joe Darcy
Chris Hegarty wrote: Thanks everyone for your very valuable feedback. From what I'm reading there doesn't seem to be a problem with defining Thread.clone to throw CloneNotSupportedException. OK, that's done. Now should it be final? It appears that there is very little value in making clone n

hg: jdk7/tl/langtools: 6976833: options included twice in Example SimpleCompiler

2010-08-16 Thread jonathan . gibbons
Changeset: a31c511db424 Author:jjg Date: 2010-08-16 14:59 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/a31c511db424 6976833: options included twice in Example SimpleCompiler Reviewed-by: darcy ! test/tools/javac/diags/Example.java

hg: jdk7/tl/jdk: 6921234: TEST_BUG: java/lang/ClassLoader/deadlock/TestCrossDelegate.sh needs to be modified for Cygwin

2010-08-16 Thread mandy . chung
Changeset: 8329ebeabc10 Author:mchung Date: 2010-08-16 15:36 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/8329ebeabc10 6921234: TEST_BUG: java/lang/ClassLoader/deadlock/TestCrossDelegate.sh needs to be modified for Cygwin Summary: Add check for CYGWIN Reviewed-by: ohair !

Re: Threads should not be Cloneable

2010-08-16 Thread David Holmes
Joe Darcy said the following on 08/17/10 06:05: The general evolution policy of the JDK [1] has long been: 1. Don't break binary compatibility (as defined in the Java Language Specification). 2. Avoid introducing source incompatibilities. 3. Manage behavioral compatibility changes.

RE: Threads should not be Cloneable

2010-08-16 Thread Jeroen Frijters
David Holmes wrote: > Fortunately, as Brian stated, compatibility is not an end unto itself > here and we often do have documented incompatibilities across major > releases. In this case there is far more harm, in my opinion, leaving > the possibility of people trying to clone threads than there is

Re: Threads should not be Cloneable

2010-08-16 Thread David Holmes
Jeroen Frijters said the following on 08/17/10 14:11: David Holmes wrote: Fortunately, as Brian stated, compatibility is not an end unto itself here and we often do have documented incompatibilities across major releases. In this case there is far more harm, in my opinion, leaving the possibilit

Re: Code review request: 6973831 NPE when printing stack trace of OOME

2010-08-16 Thread Joe Darcy
Brian Goetz wrote: So, this aspect of COIN is still somewhat new, and so I think it is worth looking at carefully. There is a specification for this feature that was discussed on coin-dev. You might want to take a look and comment -- its not too late. In particular: "Project Coin: Upd