Re: Code review request for 4881419 The type of X[].clone() should be X[]

2010-09-07 Thread David Holmes
Jeroen Frijters said the following on 09/07/10 13:58: Martin Buchholz wrote: On Sat, Sep 4, 2010 at 02:02, Jeroen Frijters wrote: Sorry to be late with my comment, but as a VM implementer I can't really agree with this modification. The return type of X[].clone() is clearly Object, no

hg: jdk7/tl/jdk: 6971706: sun/nio/cs/ext/* classes are duplicated between rt.jar, charsets.jar, and localedata.jar

2010-09-07 Thread alan . bateman
Changeset: cecc431cd78a Author:alanb Date: 2010-09-07 08:36 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/cecc431cd78a 6971706: sun/nio/cs/ext/* classes are duplicated between rt.jar, charsets.jar, and localedata.jar Reviewed-by: ohair ! make/common/Release.gmk

RE: Code review request for 4881419 The type of X[].clone() should be X[]

2010-09-07 Thread Jeroen Frijters
David Holmes wrote: > The fact that Object.clone() is implemented via a native call into the > VM is simply an implementation detail. That's not what we're talking about. We're talking about the fact that arrays (appear to) have a *public* clone method. The argument is about the return type[1]

Re: Code review request for 4881419 The type of X[].clone() should be X[]

2010-09-07 Thread David Holmes
Jeroen Frijters said the following on 09/07/10 17:59: David Holmes wrote: The fact that Object.clone() is implemented via a native call into the VM is simply an implementation detail. That's not what we're talking about. We're talking about the fact that arrays (appear to) have a *public* clon

Re: BufferedInputStream#fill() hanging in SocketInputStream#read0()

2010-09-07 Thread Alan Bateman
Andreas Kohn wrote: Hi, in an application that makes heavy use of JAX-RS, and for that reason small HTTP connections, I frequently observe situations where BufferedInputStream would hang like this: "ae03a305-557e-4db6-b9b8-2bf50f056aaf" prio=10 tid=0x2aab0175a000 nid=0x30dc runnable [0x000

Re: Code review request for 4881419 The type of X[].clone() should be X[]

2010-09-07 Thread Ulf Zibis
Am 07.09.2010 09:59, schrieb Jeroen Frijters: David Holmes wrote: The fact that Object.clone() is implemented via a native call into the VM is simply an implementation detail. That's not what we're talking about. We're talking about the fact that arrays (appear to) have a *public* clone metho

Re: Code review request for 4881419 The type of X[].clone() should be X[]

2010-09-07 Thread Ulf Zibis
Am 07.09.2010 10:50, schrieb David Holmes: Jeroen Frijters said the following on 09/07/10 17:59: David Holmes wrote: The fact that Object.clone() is implemented via a native call into the VM is simply an implementation detail. That's not what we're talking about. We're talking about the fact

Re: BufferedInputStream#fill() hanging in SocketInputStream#read0()

2010-09-07 Thread Chris Hegarty
Andreas, This stacktrace is exactly the same as what you will see if the server does not respond. The HTTP client is trying to read the initial response, but there is none. Is possible that the server is eagerly accepting the connection but not processing it? BIS should not be a problem here

Re: BufferedInputStream#fill() hanging in SocketInputStream#read0()

2010-09-07 Thread Alan Bateman
Chris Hegarty wrote: Andreas, This stacktrace is exactly the same as what you will see if the server does not respond. The HTTP client is trying to read the initial response, but there is none. Is possible that the server is eagerly accepting the connection but not processing it? I think you'

Re: Code review request for 4881419 The type of X[].clone() should be X[]

2010-09-07 Thread Joe Darcy
David Holmes wrote: Jeroen Frijters said the following on 09/07/10 17:59: David Holmes wrote: The fact that Object.clone() is implemented via a native call into the VM is simply an implementation detail. That's not what we're talking about. We're talking about the fact that arrays (appear to)

Re: Code review request for 4881419 The type of X[].clone() should be X[]

2010-09-07 Thread Joe Darcy
Jeroen Frijters wrote: David Holmes wrote: The fact that Object.clone() is implemented via a native call into the VM is simply an implementation detail. That's not what we're talking about. We're talking about the fact that arrays (appear to) have a *public* clone method. The argument

hg: jdk7/tl/langtools: 4 new changesets

2010-09-07 Thread maurizio . cimadamore
Changeset: 7ae4016c5938 Author:mcimadamore Date: 2010-09-07 17:31 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/7ae4016c5938 6337171: javac should create bridge methods when type variable bounds restricted Summary: javac should add synthetic overrides for inherited abs

hg: jdk7/tl: 2 new changesets

2010-09-07 Thread kelly . ohair
Changeset: d6ea39e0d3eb Author:ohair Date: 2010-09-07 15:13 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/rev/d6ea39e0d3eb 6982946: Change make/jprt.properties to defer to JPRT itself for jdk platform list Reviewed-by: kamg ! make/jprt.properties Changeset: b331aef4bef0 Author:

hg: jdk7/tl/jaxp: 2 new changesets

2010-09-07 Thread kelly . ohair
Changeset: cc845b339690 Author:ohair Date: 2010-09-07 15:15 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jaxp/rev/cc845b339690 6982946: Change make/jprt.properties to defer to JPRT itself for jdk platform list Reviewed-by: kamg ! make/jprt.properties Changeset: e58a0bea47f6 Auth

hg: jdk7/tl/jaxws: 2 new changesets

2010-09-07 Thread kelly . ohair
Changeset: 06c51671c84b Author:ohair Date: 2010-09-07 15:16 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jaxws/rev/06c51671c84b 6982946: Change make/jprt.properties to defer to JPRT itself for jdk platform list Reviewed-by: kamg ! make/jprt.properties Changeset: 74737bd256fa Aut

hg: jdk7/tl/corba: 2 new changesets

2010-09-07 Thread kelly . ohair
Changeset: 3821536d79ab Author:ohair Date: 2010-09-07 15:16 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/corba/rev/3821536d79ab 6982946: Change make/jprt.properties to defer to JPRT itself for jdk platform list Reviewed-by: kamg ! make/jprt.properties Changeset: 0a91416c1402 Aut

hg: jdk7/tl/jdk: 2 new changesets

2010-09-07 Thread kelly . ohair
Changeset: df049d0b973f Author:ohair Date: 2010-09-07 15:17 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/df049d0b973f 6982946: Change make/jprt.properties to defer to JPRT itself for jdk platform list Reviewed-by: kamg ! make/jprt.properties Changeset: 299955417217 Autho

hg: jdk7/tl/langtools: 2 new changesets

2010-09-07 Thread kelly . ohair
Changeset: 47e7ff871196 Author:ohair Date: 2010-09-07 15:14 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/47e7ff871196 6982946: Change make/jprt.properties to defer to JPRT itself for jdk platform list Reviewed-by: kamg ! make/jprt.properties Changeset: c388fa8c6a43