Re: 6613829: (docs) Readable.read() ReadOnlyBufferException is not linked

2010-11-16 Thread Lance Andersen - Oracle
Looks good to me Alan. Regards Lance On Nov 16, 2010, at 9:34 AM, Alan Bateman wrote: > I need a reviewer to a trivial drive-by fix to java.lang.Readable's javadoc. > > Thanks, > Alan. > > diff --git a/src/share/classes/java/lang/Readable.java > b/src/share/classes/java/lang/Readable.java > --

Re: 6613829: (docs) Readable.read() ReadOnlyBufferException is not linked

2010-11-16 Thread Chris Hegarty
Alan, Looks fine. -Chris. Alan Bateman wrote: I need a reviewer to a trivial drive-by fix to java.lang.Readable's javadoc. Thanks, Alan. diff --git a/src/share/classes/java/lang/Readable.java b/src/share/classes/java/lang/Readable.java --- a/src/share/classes/java/lang/Readable.java +++ b/

hg: jdk7/tl/jdk: 6613829: (docs) Readable.read() ReadOnlyBufferException is not linked

2010-11-16 Thread alan . bateman
Changeset: 9ec7802cc759 Author:alanb Date: 2010-11-16 15:23 + URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/9ec7802cc759 6613829: (docs) Readable.read() ReadOnlyBufferException is not linked Reviewed-by: chegar, lancea ! src/share/classes/java/lang/Readable.java

hg: jdk7/tl/corba: 2 new changesets

2010-11-16 Thread rob . mckenna
Changeset: f642c9ec81a0 Author:robm Date: 2010-11-15 10:46 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/corba/rev/f642c9ec81a0 6277781: Serialization of Enums over IIOP is broke. Summary: Reviewed by Ken Cavanaugh Reviewed-by: coffeys ! src/share/classes/com/sun/corba/se/impl/io/I

Re: Please review java.util.jar.pack.* cleanup/refactoring/generificaiton

2010-11-16 Thread Mike Duigou
Attribute.java/Instruction.java/Package.java.File : - Layout.equals(Object x) { return x instanceof Layout && equals((Layout)x); } should be : Layout.equals(Object x) { return (null != x) && (x.getClass() == Layout.class) && equals((Layout)x); } as sub-classes also using instanceof would

hg: jdk7/tl/jdk: 3 new changesets

2010-11-16 Thread valerie . peng
Changeset: 86ea594c1d10 Author:valeriep Date: 2010-11-15 14:32 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/86ea594c1d10 6848930: JSN security test jce/Global/Cipher/PKCS5Padding cannot thrown expected BadPaddingException Summary: Disabled CKM_DES_CBC_PAD, CKM_DES3_CBC_PAD

hg: jdk7/tl/corba: 5 new changesets

2010-11-16 Thread abhi . saha
Changeset: e0f7ed041196 Author:skoppar Date: 2010-10-07 00:59 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/corba/rev/e0f7ed041196 6714797: InitialContext.close does not close NIO socket connections Reviewed-by: asaha ! src/share/classes/com/sun/corba/se/impl/transport/CorbaConnec

70000691 : (coll) (doc) ConcurrentLinkedQueue @link to ConcurrentModificationException

2010-11-16 Thread Mike Duigou
I'll ask the same as Alan for a small doc review for ConcurrentLinkedQueue Thanks, Mike diff --git a/src/share/classes/java/util/concurrent/ConcurrentLinkedQueue.java b/src/share/classes/java/util/concurrent/ConcurrentLinkedQueue.java --- a/src/share/classes/java/util/concurrent/ConcurrentLinked

Re: 70000691 : (coll) (doc) ConcurrentLinkedQueue @link to ConcurrentModificationException

2010-11-16 Thread Rémi Forax
Le 17/11/2010 00:39, Mike Duigou a écrit : I'll ask the same as Alan for a small doc review for ConcurrentLinkedQueue Thanks, Mike diff --git a/src/share/classes/java/util/concurrent/ConcurrentLinkedQueue.java b/src/share/classes/java/util/concurrent/ConcurrentLinkedQueue.java --- a/src/share/