Re: Review Request -- CR6565585: Performance improvements to Method.invoke(), Contrstuctor.newInstance() and Field.getFieldAccessor()

2011-03-22 Thread Alan Bateman
Mike Duigou wrote: I've updated the patch to avoid the second read-volatile by having the acquire* methods return a result. Method already used that approach. I am less certain about tackling additional improvements to the caching in this patch. In part because I suspect that the usage pattern

hg: jdk7/tl/jdk: 6737397: Should support running JCK test suite with test/Makefile and JPRT

2011-03-22 Thread kelly . ohair
Changeset: 870f7c3f0b61 Author:ohair Date: 2011-03-22 11:08 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/870f7c3f0b61 6737397: Should support running JCK test suite with test/Makefile and JPRT Reviewed-by: alanb ! make/jprt.properties ! test/Makefile ! test/ProblemList.txt

Re: core-libs-dev Digest, Vol 47, Issue 35

2011-03-22 Thread Guy Korland
It seems like a great improvement that can help many frameworks. Is there any plan to port the fix to JDK6? Thanks, Guy Date: Mon, 21 Mar 2011 16:29:22 -0700 From: Mike Duigou Subject: Re: Review Request -- CR656558

Review Request : 7029997 : Restyling of SortedMap Javadoc

2011-03-22 Thread Mike Duigou
Hello all; I have made a couple of styling improvements to the JavaDoc for SortedMap; principally conversion of an inline list to use the HTML tag. The remainder of the changes are updates to the standard javadoc tags. http://cr.openjdk.java.net/~mduigou/7029997/0/webrev/ Thanks, Mike

Re: core-libs-dev Digest, Vol 47, Issue 35

2011-03-22 Thread Mike Duigou
I am not aware of any current plans to backport this improvement to JDK6. For performance related patches the normal backporting path is for their the patch to be ported by the Oracle Java performance team or by the Java for Business team to fulfill a licensee support request. Development effort

Re: core-libs-dev Digest, Vol 47, Issue 35

2011-03-22 Thread Guy Korland
For the method.invoke most of the usage I see is in RPC (RMI and etc.) and a very common case of annotation based AOP (which is very common when using frameworks like Spring). Guy On Tue, Mar 22, 2011 at 10:26 PM, Mike Duigou wrote: > I am not aware of any current plans to backport this improve

Re: Review Request : 7029997 : Restyling of SortedMap Javadoc

2011-03-22 Thread Chris Hegarty
The changes look good. I have two minor comment: 1) "ranges.Such" typo, missing space after dot 2) "Though nothing enforces this recommendation as interfaces cannot declare constructors". I'd tend to move this statement to before the list, and maybe put it in parantheses after construct

Re: Review Request : 7029997 : Restyling of SortedMap Javadoc

2011-03-22 Thread Mike Duigou
Thanks for the feedback. On Mar 22 2011, at 16:12 , Chris Hegarty wrote: > The changes look good. > > I have two minor comment: > > 1) "ranges.Such" typo, missing space after dot corrected. > > 2) "Though nothing enforces this recommendation as interfaces cannot >declare constructors". I

Re: Review Request : 7029997 : Restyling of SortedMap Javadoc

2011-03-22 Thread Joe Darcy
On 3/22/2011 4:33 PM, Mike Duigou wrote: [snip] 2) "Though nothing enforces this recommendation as interfaces cannot declare constructors". I'd tend to move this statement to before the list, and maybe put it in parantheses after constructors. Also my personal preference is to stay

hg: jdk7/tl/langtools: 7025314: NLS: translatability violation on standard.properties

2011-03-22 Thread bhavesh . patel
Changeset: 148d3dc4e1e1 Author:bpatel Date: 2011-03-22 18:32 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/148d3dc4e1e1 7025314: NLS: translatability violation on standard.properties Reviewed-by: jjg ! src/share/classes/com/sun/tools/doclets/formats/html/markup/HtmlWr