Re: Review Request : 7029997 : Restyling of SortedMap Javadoc

2011-03-23 Thread Chris Hegarty
On 03/22/11 11:33 PM, Mike Duigou wrote: .. How about this version : *All general-purpose sorted map implementation classes should provide four * "standard" constructors. It is not possible to enforce this recommendation * though as required constructors cannot be specified by interfac

A method with return type size_t returns negative value

2011-03-23 Thread Jing LV
Hello, I found a problem in windows/native/java/io/io_util_md.c, method handleRead(). The return type of the method is size_t, which is defined as unsigned int. However we see the method would return negative values while it meets some error. This may be a problem as the API comsumer and later dev

Re: A method with return type size_t returns negative value

2011-03-23 Thread Alan Bateman
Jing LV wrote: Hello, I found a problem in windows/native/java/io/io_util_md.c, method handleRead(). The return type of the method is size_t, which is defined as unsigned int. However we see the method would return negative values while it meets some error. This may be a problem as the API comsu

hg: jdk7/tl/jdk: 7028490: better suggestion for jarsigner when TSA is not accessible

2011-03-23 Thread weijun . wang
Changeset: c43811a602a8 Author:weijun Date: 2011-03-23 18:26 +0800 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/c43811a602a8 7028490: better suggestion for jarsigner when TSA is not accessible Reviewed-by: mullan ! src/share/classes/sun/security/tools/JarSigner.java ! src/share/

hg: jdk7/tl/langtools: 7010342: End tag for element P is not open for few html files generated using new javadoc

2011-03-23 Thread bhavesh . patel
Changeset: 72bdd232e0ea Author:bpatel Date: 2011-03-23 14:40 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/72bdd232e0ea 7010342: End tag for element P is not open for few html files generated using new javadoc Reviewed-by: jjg ! src/share/classes/com/sun/tools/docle

Suspected regression: fix for 6735255 causes delay in GC of ZipFile InputStreams, increase in heap demand

2011-03-23 Thread Neil Richards
Hi, I've noticed that the fix introduced to address bug 6735255 [1] [2] had an unfortunate side-effect. That fix stores references to the InputStream objects returned from ZipFile.getInputStream(ZipEntry) in a HashSet (within ZipFile), so that the close() method may be called upon those objects wh

hg: jdk7/tl/jdk: 7029997: Restyling of SortedMap Javadoc

2011-03-23 Thread mike . duigou
Changeset: b58572df94f1 Author:mduigou Date: 2011-03-23 15:01 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/b58572df94f1 7029997: Restyling of SortedMap Javadoc Reviewed-by: darcy, chegar ! src/share/classes/java/util/SortedMap.java

Review Request : 7030442 : Add missing @param to Collections.reverseOrder()

2011-03-23 Thread Mike Duigou
Hi All; More documentation nits for review. :-) (and more of these to come as we push closer to Java 7 code freeze) This one adds the missing @param cmp tag for Collections.reverseOrder. The description text is adapted from the general method javadoc. http://cr.openjdk.java.net/~mduigou/703044

Re: Review Request : 7030442 : Add missing @param to Collections.reverseOrder()

2011-03-23 Thread joe . darcy
On 3/23/2011 3:32 PM, Mike Duigou wrote: Hi All; More documentation nits for review. :-) (and more of these to come as we push closer to Java 7 code freeze) This one adds the missing @param cmp tag for Collections.reverseOrder. The description text is adapted from the general method javadoc.

Request for review: 6312706: Map entrySet iterators should return different entries on each call to next()

2011-03-23 Thread Neil Richards
As previously trailed [1], please find below a suggested change to address the problem reported in bug 6312706 [2], together with testcases to demonstrate the veracity of the change. The change causes the entry set iterators for java.util.EnumMap and java.util.IdentityHashMap to return distinct Ma

hg: jdk7/tl/jdk: 7029848: KeyStoreBuilderParameters((Builder)null) does not throw NullPointerException

2011-03-23 Thread xuelei . fan
Changeset: 3fee1c67bd10 Author:xuelei Date: 2011-03-23 20:07 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/3fee1c67bd10 7029848: KeyStoreBuilderParameters((Builder)null) does not throw NullPointerException Summary: throws NPE for null Builder Reviewed-by: weijun ! src/shar

hg: jdk7/tl/jdk: 7030523: regression: imporper checking of paramater

2011-03-23 Thread xuelei . fan
Changeset: b921112e39d3 Author:xuelei Date: 2011-03-23 20:25 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/b921112e39d3 7030523: regression: imporper checking of paramater Reviewed-by: weijun ! src/share/classes/javax/net/ssl/KeyStoreBuilderParameters.java