Re: Review request for removal of unchecked lint warnings in javax.sql.rowset, CR 7035615

2011-04-12 Thread Alan Bateman
Lance Andersen - Oracle wrote: Hi Alan, Joe I pushed the revised webrev out (webrev.01). I am going through a directory at time to resolve the lint errors and found a few additional classes to address in com.sun.rowset (as I had not looked at this directory yet) which you will see in the

Re: Review request for removal of unchecked lint warnings in javax.sql.rowset, CR 7035615

2011-04-12 Thread Lance Andersen - Oracle
Hi Alan, http://cr.openjdk.java.net/~lancea/7035615/webrev.02/ has your suggested changes below. Regards Lance On Apr 12, 2011, at 4:08 AM, Alan Bateman wrote: > Lance Andersen - Oracle wrote: >> Hi Alan, Joe >> >> >> I pushed the revised webrev out (webrev.01). I am going through a direct

hg: jdk7/tl/jdk: 6882437: CertPath/X509CertPathDiscovery/Test fails on jdk7/pit/b62

2011-04-12 Thread xuelei . fan
Changeset: 6e306c3aa17b Author:xuelei Date: 2011-04-12 08:27 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/6e306c3aa17b 6882437: CertPath/X509CertPathDiscovery/Test fails on jdk7/pit/b62 Summary: Pass trust anchors to CRL certification path building, support CRLs without AK

hg: jdk7/tl/jdk: 7035615: Address lint warnings for javax.sql.rowset & com.sun.rowset

2011-04-12 Thread lance . andersen
Changeset: 1bb95f6ac753 Author:lancea Date: 2011-04-12 12:25 -0400 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/1bb95f6ac753 7035615: Address lint warnings for javax.sql.rowset & com.sun.rowset Reviewed-by: alanb, darcy ! src/share/classes/com/sun/rowset/CachedRowSetImpl.java !

Re: Constants for standard charsets -- CR #4884238

2011-04-12 Thread Mike Duigou
On Apr 12 2011, at 03:33 , Alan Bateman wrote: > Alan Bateman wrote: >> I see your mail in the archives: >> >> http://mail.openjdk.java.net/pipermail/core-libs-dev/2011-April/006487.html >> >> but I didn't receive it. I had a similar issue yesterday on another list but >> I've no idea where t

Quick code review to address a couple typos in the javadoc for ResultSet, CR 7007772

2011-04-12 Thread Lance Andersen - Oracle
Hi folks, Looking for a reviewer for the following simple change to ResultSet to address CR 7007772 hg diff diff -r 1bb95f6ac753 src/share/classes/java/sql/ResultSet.java --- a/src/share/classes/java/sql/ResultSet.java Tue Apr 12 12:25:15 2011 -0400 +++ b/src/share/classes/java/sql/ResultSet.jav

Re: Quick code review to address a couple typos in the javadoc for ResultSet, CR 7007772

2011-04-12 Thread Stuart Marks
Lance, Looks fine to me. s'marks On 4/12/11 10:57 AM, Lance Andersen - Oracle wrote: Hi folks, Looking for a reviewer for the following simple change to ResultSet to address CR 7007772 hg diff diff -r 1bb95f6ac753 src/share/classes/java/sql/ResultSet.java --- a/src/share/classes/java/sql/R

Re: Constants for standard charsets -- CR #4884238

2011-04-12 Thread Mike Duigou
On Apr 12 2011, at 11:11 , mark.reinh...@oracle.com wrote: > 2011/4/12 10:38 -0700, mike.dui...@oracle.com: >> On Apr 12 2011, at 03:33 , Alan Bateman wrote: >>> ... >>> >>> 2. @see Charsets.DEFAULT, I assume this should be @see >>> Charsets#DEFAULT_CHARSET >> >> Correct. I changed it to DEFAU

hg: jdk7/tl/jdk: 7007772: Address typos in javadoc for ResultSet

2011-04-12 Thread lance . andersen
Changeset: 0bae251b548b Author:lancea Date: 2011-04-12 14:32 -0400 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/0bae251b548b 7007772: Address typos in javadoc for ResultSet Reviewed-by: ohair, smarks ! src/share/classes/java/sql/ResultSet.java

Re: Constants for standard charsets -- CR #4884238

2011-04-12 Thread Ulf Zibis
Am 12.04.2011 20:27, schrieb Mike Duigou: On Apr 12 2011, at 11:11 , mark.reinh...@oracle.com wrote: 2011/4/12 10:38 -0700, mike.dui...@oracle.com: On Apr 12 2011, at 03:33 , Alan Bateman wrote: ... 2. @see Charsets.DEFAULT, I assume this should be @see Charsets#DEFAULT_CHARSET Correct. I c

Re: Suspected regression: fix for 6735255 causes delay in GC of ZipFile InputStreams, increase in heap demand

2011-04-12 Thread Xueming Shen
Hi Neil, (1) I believe it would be better to keep the synchronization lock for get/releaseInfalter() "local" instead of using the "global" ZipFile.this, which I agree is "simple". But it also means each/every time when you release the used inflater back to cache, ZipFile.this ha

Re: Constants for standard charsets -- CR #4884238

2011-04-12 Thread Ulf Zibis
Am 12.04.2011 21:10, schrieb Ulf Zibis: > This change has been previously proposed but the constants were to be defined in Charset which was deemed to have too high a static initialization cost. Using a separate class, Charsets, means that the cost for initialization is only borne by those who

hg: jdk7/tl/jdk: 7035555: 4/4 attach/BasicTests.sh needs another tweak for Cygwin

2011-04-12 Thread daniel . daugherty
Changeset: 59b2b9a34b3c Author:dcubed Date: 2011-04-12 13:36 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/59b2b9a34b3c 703: 4/4 attach/BasicTests.sh needs another tweak for Cygwin Summary: Test needs to properly detect missing AgentInitializationException. Clarify when

Heads up, new jaxws source drop bundle

2011-04-12 Thread Kelly O'Hair
7034918: Integrate JAX-WS 2.2.4-b01 in to JDK 7 http://cr.openjdk.java.net/~ohair/openjdk7/jaxws-7034918/webrev/ More details on the changes here: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7034918 The new jaxws source drop bundle is called: jdk7-jaxws2_2_4-b01-2011_04_08.zip So if

hg: jdk7/tl/jaxws: 7034918: Integrate JAX-WS 2.2.4-b01 in to JDK 7

2011-04-12 Thread kelly . ohair
Changeset: d5e3452a6909 Author:ohair Date: 2011-04-12 12:39 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jaxws/rev/d5e3452a6909 7034918: Integrate JAX-WS 2.2.4-b01 in to JDK 7 Reviewed-by: ramap ! jaxws.properties

Re: Constants for standard charsets -- CR #4884238

2011-04-12 Thread Mike Duigou
On Apr 12 2011, at 12:10 , Ulf Zibis wrote: > Am 12.04.2011 20:27, schrieb Mike Duigou: >> This change has been previously proposed but the constants were to be >> defined in Charset which was deemed to have too high a static initialization >> cost. Using a separate class, Charsets, means that

Re: advice & review requested for 6896297, race condition in rmid causing JCK failure

2011-04-12 Thread Stuart Marks
Hi David, Thanks for your notes and analysis. Good point about the temporary inconsistency between groupEntry and groupTable. With the change, there's a brief moment where a GroupEntry in the registered state can be observed to be absent from the groupTable, which wasn't possible before. I don

Re: Constants for standard charsets -- CR #4884238

2011-04-12 Thread Ulf Zibis
Am 12.04.2011 23:25, schrieb Mike Duigou: On Apr 12 2011, at 12:10 , Ulf Zibis wrote: Am 12.04.2011 20:27, schrieb Mike Duigou: This change has been previously proposed but the constants were to be defined in Charset which was deemed to have too high a static initialization cost. Using a sep

Fwd: [concurrency-interest] ConcurrentHashMap footprint and contention improvements

2011-04-12 Thread Doug Lea
Members of this list are also invited to check this out. I'm not sure if it will make Java7 schedule, but the improvements seem worthwhile given the increased use of ConcurrentHashMap inside the JDK (including multiple tables per class loader in JDK7.) -Doug Original Message

Re: proposal to optimise the performance of the Jar utility

2011-04-12 Thread mike . skells
Hi Sherman, I have had a quick look at the current code to see what 'low hanging fruit' there is. I appreciate that parallelizing the command in its entirity may not be feasible for the first release The tests that I have run are jarring the content of the 1.7 rt.jar with varying compression

hg: jdk7/tl/jdk: 2 new changesets

2011-04-12 Thread valerie . peng
Changeset: 5d132f3bfbbf Author:valeriep Date: 2011-04-12 15:57 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/5d132f3bfbbf 7001094: Can't initialize SunPKCS11 more times than PKCS11 driver maxSessionCount Summary: Changed SessionManager to keep track of session count for eac

hg: jdk7/tl/jdk: 7026304: Fork-Join sample

2011-04-12 Thread rickard . backman
Changeset: 9128eace50f5 Author:rbackman Date: 2011-04-12 13:14 +0200 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/9128eace50f5 7026304: Fork-Join sample Summary: Implement a merge-sort sample using Fork-Join Reviewed-by: hosterda, chegar, dholmes ! make/mksample/Makefile + make/

Re: Codereview request for 7033561: Missing Unicode Script aliases

2011-04-12 Thread Masayoshi Okutsu
The fix looks good to me. Masayoshi On 4/7/2011 5:42 AM, Xueming Shen wrote: Thanks! webrev has been updated accordingly. -Sherman On 04/06/2011 01:29 PM, Alan Bateman wrote: Xueming Shen wrote: It appears the aliases mapping for Character.UnicodeScript is not updated accordingly when we

Re: Need reviewers: Update of jaxp 1.4.5 source drop bundle

2011-04-12 Thread Joe Wang
Sorry for the late answer to this question. I was on a long vacation. Please see inline below. On 4/7/2011 7:04 AM, Dalibor Topic wrote: On 4/7/11 3:49 PM, Dr Andrew John Hughes wrote: On 07/04/2011, Dalibor Topic wrote: On 3/3/11 3:01 AM, Dr Andrew John Hughes wrote: How do

hg: jdk7/tl/langtools: 2 new changesets

2011-04-12 Thread maurizio . cimadamore
Changeset: f00986f55961 Author:mcimadamore Date: 2011-04-12 20:56 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/f00986f55961 7034511: Loophole in typesafety Summary: Type-variable substutution takes upper bound of replaced captured type-variable Reviewed-by: dlsmith

Re: Request for review: 6597112: Referential integrity loophole during remote object export

2011-04-12 Thread Peter Jones
Neil, On Apr 8, 2011, at 1:17 PM, Neil Richards wrote: > Hi Peter, > Thank you for your review on this problem - it really helped in > highlighting some invalid assumptions I was making about the way that > the RMI code behaves. > > I had assumed that, once the stub is returned from exportObject,