Re: Review request 7039809: Remove @ConstructorProperties annotation from java.io.File class
Mandy Chung wrote: Sergey, Alan, Can you review the fix for: 7039809: Remove @ConstructorProperties annotation from java.io.File class Webrev at: http://cr.openjdk.java.net/~mchung/jdk7/7039809/webrev.00/ Looks good to me. -Alan.
Re: Review request the fix for CR 7040150
On Apr 28, 2011, at 11:52 PM, Stuart Marks wrote: On 4/28/11 11:13 AM, Lance Andersen - Oracle wrote: Hi all, I could use a reviewer for 7040150 which addresses a positioning issue with CacheResultSetImpl.removeCurrentRow(). The diff is located at: http://cr.openjdk.java.net/~lancea/7040150/webrev.00/ The change in the index value looks correct. It's hard to say, but it looks like removeCurrentRow() doesn't throw SQLException if the cursor is on the insert row. In that case, it might throw ClassCastException when the InsertRow is cast to Row. Also, if the cursor is before the first row, it might throw ArrayIndexOutOfBoundsException. Then again, it says this is a implementation only method [sic] as opposed to a public method, so it's hard to say whether it needs to handle all these cases, as they might not actually arise in practice. I guess if the change is sufficient to fix the customer's problem, then go ahead with it. Thanks Stuart. This method is only called by setOriginalRow which does check for insertRow. It does address the customer issue and allows the TCK to continue to pass. Best Regards, Lance s'marks Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037 Oracle Java Engineering 1 Network Drive Burlington, MA 01803 lance.ander...@oracle.com
hg: jdk7/tl/jdk: 7040150: Indexing Error in CachedRowSetImpl.removeCurrentRow
Changeset: 0b1354ecf5a3 Author:lancea Date: 2011-04-29 09:04 -0400 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/0b1354ecf5a3 7040150: Indexing Error in CachedRowSetImpl.removeCurrentRow Reviewed-by: smarks ! src/share/classes/com/sun/rowset/CachedRowSetImpl.java
hg: jdk7/tl/jdk: 7039809: Remove @ConstructorProperties annotation from java.io.File class
Changeset: 24ad188dc46c Author:mchung Date: 2011-04-29 08:51 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/24ad188dc46c 7039809: Remove @ConstructorProperties annotation from java.io.File class Reviewed-by: alanb, malenkov ! src/share/classes/java/io/File.java - test/java/beans/XMLEncoder/java_io_File.java
hg: jdk7/tl/langtools: 4 new changesets
Changeset: 4c03383f6529 Author:mcimadamore Date: 2011-04-29 16:05 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/4c03383f6529 7040104: javac NPE on Object a[]; Object o = (a=null)[0]; Summary: When a null literal is found on top of stack, if expected type is 1-dimension array no checkcast is emitted Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/jvm/Code.java + test/tools/javac/T7040104.java Changeset: 9a847a77205d Author:mcimadamore Date: 2011-04-29 16:05 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/9a847a77205d 7039937: Improved catch analysis fails to handle a common idiom in the libraries Summary: Disable generation of 'unreachable catch' warnings for catch statements catching Exception/Throwable Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/comp/Flow.java ! test/tools/javac/6558548/T6558548.java ! test/tools/javac/6558548/T6558548_6.out ! test/tools/javac/6558548/T6558548_latest.out ! test/tools/javac/diags/examples/UnreachableCatch1.java Changeset: 1092b67b3cad Author:mcimadamore Date: 2011-04-29 16:05 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/1092b67b3cad 7034495: Javac asserts on usage of wildcards in bounds Summary: Problem with intersection types and wildcards causing javac to crash Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/code/Types.java + test/tools/javac/generics/wildcards/7034495/T7034495.java + test/tools/javac/generics/wildcards/7034495/T7034495.out Changeset: dc3d9ef880a1 Author:mcimadamore Date: 2011-04-29 16:06 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/dc3d9ef880a1 6550655: com.sun.tools.javac.code.Symbol$CompletionFailure Summary: Accessing a non-existing enum constant from an annotation whose class is available results in an internal error Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/comp/Annotate.java ! src/share/classes/com/sun/tools/javac/jvm/ClassReader.java ! src/share/classes/com/sun/tools/javac/resources/compiler.properties + test/tools/javac/annotations/6550655/T6550655.java ! test/tools/javac/diags/examples.not-yet.txt
Re: Codereview request: CR 7040220 java/char_encodin Optimize UTF-8 charset for String.getBytes()/toCharArray()
On 28 April 2011 12:01, Alan Bateman alan.bate...@oracle.com wrote: I skimmed through the webrev and I agree this is a better approach. I will try to do a detailed review before Monday. It would be great if others on the list could jump in and help too as we are running out of time. Neil - I don't know if you've had a chance to look at Sherman's changes but I think it's better than checking if mUTF-8 can be used. If you agree then would you have time to run your tests that altered you to this performance regression? There's a patch file in the webrev. Hi Sherman, Thank you for responding so quickly to my post. I realise that my suggested change was quite restricted in its scope - it was designed so it could be considered easily (in the hope it might make it through the OpenJDK 7 gates before they finally clang shut). However, it's evident from your response that you have been thinking about possible enhancements in this area, and I agree that your proposed change addresses the issue in a more comprehensive - and strategic - manner. From the testing I've been able to look at thus far, your proposed change seems to address the performance penalty which had caused me to raise the matter. Given this, I'd be delighted if it is adopted into OpenJDK 7, Thanks once again, Neil -- Unless stated above: IBM email: neil_richards at uk.ibm.com IBM United Kingdom Limited - Registered in England and Wales with number 741598. Registered office: PO Box 41, North Harbour, Portsmouth, Hampshire PO6 3AU
hg: jdk7/tl/jaxp: 7040147: jaxp 1.4.5 jdk7 integration
Changeset: 30129a58aacc Author:ohair Date: 2011-04-29 10:58 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jaxp/rev/30129a58aacc 7040147: jaxp 1.4.5 jdk7 integration Reviewed-by: joehw ! jaxp.properties
hg: jdk7/tl/jdk: 7036252: sunpkcs11-solaris.cfg needs a review
Changeset: 40e2b3a25533 Author:valeriep Date: 2011-04-29 13:31 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/40e2b3a25533 7036252: sunpkcs11-solaris.cfg needs a review Summary: Updated the disabled mechanisms section since Solaris bug 6306708 has been fixed. Reviewed-by: mullan ! src/share/lib/security/sunpkcs11-solaris.cfg
hg: jdk7/tl/jdk: 7040572: Fix broken java/nio/charset/StandardCharset/Standard.java and add more tests.
Changeset: 36dd30b5f85d Author:mduigou Date: 2011-04-29 14:09 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/36dd30b5f85d 7040572: Fix broken java/nio/charset/StandardCharset/Standard.java and add more tests. Reviewed-by: alanb ! test/java/nio/charset/StandardCharset/Standard.java
