Alexandre Boulgakov said the following on 08/03/11 04:44:
On 8/2/2011 2:19 AM, Xuelei Fan wrote:
3017 Vector temp = (Vector)extractURLs(res.errorMessage);
You may not need the conversion any more, the return value of
extractURLs() has been updated to
2564 private static Vector extr
Mike Duigou wrote:
Hello All;
A fairly simple bug to review which snuck through testing.
http://cr.openjdk.java.net/~mduigou/7073296/0/webrev/
The changes to Class are incidental but so trivial that opted to include them.
I can remove if anyone feels strongly (or even weakly) that they should
On Wed, 2011-07-20 at 22:16 +1000, David Holmes wrote:
> However, unless I'm missing something subtle, why do we need to check
> for the method being abstract? Aren't all interface methods always
> implicitly abstract?
Hi David,
Thanks for looking at my suggestion.
Firstly, let me correct myse
Hi,
I've noticed that jdk/src/share/bin/jli_util.h does not currently
include the ANSI headers for the functions that it #defines aliases for,
which is not good practice.
Please find below a suggested change which adds the necessary #include
statements to correct this.
Please consider this change
On 8/3/2011 12:42 AM, David Holmes wrote:
Alexandre Boulgakov said the following on 08/03/11 04:44:
On 8/2/2011 2:19 AM, Xuelei Fan wrote:
3017 Vector temp = (Vector)extractURLs(res.errorMessage);
You may not need the conversion any more, the return value of
extractURLs() has been updated
On 09:24 Wed 03 Aug , Joe Darcy wrote:
> On 8/3/2011 12:42 AM, David Holmes wrote:
> > Alexandre Boulgakov said the following on 08/03/11 04:44:
> >> On 8/2/2011 2:19 AM, Xuelei Fan wrote:
> >>> 3017 Vector temp = (Vector)extractURLs(res.errorMessage);
> >>> You may not need the conversion
Please see my responses inline.
Thanks!
-Sasha
On 8/2/2011 9:13 PM, Xuelei Fan wrote:
. com/sun/jndi/toolkit/dir/SearchFilter.java
451 for (NamingEnumeration ve = attr.getAll();
452 ve.hasMore();
453) {
The update is OK. But the coding style looks un
On 8/3/2011 10:51 AM, Dr Andrew John Hughes wrote:
On 09:24 Wed 03 Aug , Joe Darcy wrote:
On 8/3/2011 12:42 AM, David Holmes wrote:
Alexandre Boulgakov said the following on 08/03/11 04:44:
On 8/2/2011 2:19 AM, Xuelei Fan wrote:
3017 Vector temp = (Vector)extractURLs(res.errorMessage);
On Wed, 2011-08-03 at 11:03 -0700, Alexandre Boulgakov wrote:
> Please see my responses inline.
>
> Thanks!
> -Sasha
>
> On 8/2/2011 9:13 PM, Xuelei Fan wrote:
> > . com/sun/jndi/toolkit/dir/SearchFilter.java
> > 451 for (NamingEnumeration ve = attr.getAll();
> > 452 ve.
Users of Iterable expect to call Iterable.iterator() multiple times,
receiving a fresh iterator pointing to the beginning of the Iterable
each time. This would not be possible to do with an Enumeration wrapper
since Enumerations are read-once.
I don't know if this is a strong enough reason not
On 8/4/2011 2:03 AM, Alexandre Boulgakov wrote:
> Please see my responses inline.
>
> Thanks!
> -Sasha
>
> On 8/2/2011 9:13 PM, Xuelei Fan wrote:
>> . com/sun/jndi/toolkit/dir/SearchFilter.java
>> 451 for (NamingEnumeration ve = attr.getAll();
>> 452 ve.hasMore();
>> 4
Joe Darcy said the following on 08/04/11 02:24:
On 8/3/2011 12:42 AM, David Holmes wrote:
Alexandre Boulgakov said the following on 08/03/11 04:44:
On 8/2/2011 2:19 AM, Xuelei Fan wrote:
3017 Vector temp = (Vector)extractURLs(res.errorMessage);
You may not need the conversion any more, th
David Holmes wrote:
Joe Darcy said the following on 08/04/11 02:24:
On 8/3/2011 12:42 AM, David Holmes wrote:
Alexandre Boulgakov said the following on 08/03/11 04:44:
On 8/2/2011 2:19 AM, Xuelei Fan wrote:
3017 Vector temp = (Vector)extractURLs(res.errorMessage);
You may not need the co
PS Looking in src/share/classes/com/sun/jndi/dns/DnsContext.java, for
this code
1085 public Binding nextElement() {
1086 try {
1087 return next();
1088 } catch (NamingException e) {
1089 throw (new java.util.NoSuchElementException(
1090
Joe Darcy said the following on 08/04/11 12:33:
David Holmes wrote:
Using wildcards makes the subtyping work along the type argument axis.
So what is the right fix here? To declare the underlying Vector as a
Vector and cast it to something concrete when needed? It seems very
wrong to me to b
David Holmes wrote:
Joe Darcy said the following on 08/04/11 12:33:
David Holmes wrote:
Using wildcards makes the subtyping work along the type argument axis.
So what is the right fix here? To declare the underlying Vector as a
Vector and cast it to something concrete when needed? It seems
16 matches
Mail list logo
