hg: jdk8/tl/jdk: 7090843: (tz) Support tzdata2011j

2011-09-15 Thread yuka . kamiya
Changeset: 5e403e9fa34a Author:peytoia Date: 2011-09-15 15:02 +0900 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/5e403e9fa34a 7090843: (tz) Support tzdata2011j Reviewed-by: okutsu ! make/sun/javazic/tzdata/VERSION ! make/sun/javazic/tzdata/africa !

Re: code review request: 7051946: Runtime.exec(String command) / ProcessBuilder command parsing issues

2011-09-15 Thread Alan Bateman
Alan Bateman wrote: Michael McMahon wrote: We could add a sentence to the existing @throws clause for IAE. So it would say If |command| is empty, or on some platforms, may be thrown if command contains illegal characters. I'm reluctant to be more precise than that, since as far as I know,

RE: code review request: 7051946: Runtime.exec(String command) / ProcessBuilder command parsing issues

2011-09-15 Thread Jeroen Frijters
Hi, I'm not a formal reviewer, but I've implemented this same thing for IKVM.NET which has to simulate the behavior of CreateProcess when running on Windows (because it uses the .NET API to start a process and that doesn't have this hack). Your algorithm doesn't match CreateProcess, because

Re: [JDK] Code Review 7090499: missing rawtypes warnings in anonymous inner class

2011-09-15 Thread Alan Bateman
Chris Hegarty wrote: This review is for the JDK part of CR 7090499: missing rawtypes warnings in anonymous inner class. Recently, Sasha removed all warnings from some areas of the jdk and enabled -Werror. Once 7090499 is fixed in javac then the JDK build would fail if using raw types in any

hg: jdk8/tl/jdk: 2 new changesets

2011-09-15 Thread michael . x . mcmahon
Changeset: 9281d65f911a Author:michaelm Date: 2011-09-15 13:50 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/9281d65f911a 7073491: -Dsun.net.maxDatagramSockets=1 does not work correctly with system.gc() Reviewed-by: ngmr !