core-libs-dev@openjdk.java.net

2011-11-04 Thread Heiko Wagner
I hope this is the right list to post this. I encounter some behaviour, that I am not sure whether this is correct. When invoking ResourceBundle.getBundle("com.some.Bundle") I get a ArrayIndexOutOfBoundsException. This is caused by the fact that the ResourceBundle class tries to determine the actu

core-libs-dev@openjdk.java.net

2011-11-04 Thread Tom Hawtin
On 04/11/11 09:58, Heiko Wagner wrote: This is caused by the fact that the ResourceBundle class tries to determine the actual ClassLoader using the getLoader() method, via accessing the hardcoded stack offset 2, which works when the getBundle() method is callen from Java, but in my case I invoke

core-libs-dev@openjdk.java.net

2011-11-04 Thread Heiko Wagner
Hi Tom, thanks for your reply. I am using JNI in a different,propably never designed to be used that way, kind of scenario. I use JNI to bring Java to a legacy Smalltalk based product[1]. The Smalltalk code does directly invoke the JNI calls from its own Smalltalk VM main thread. So the Java VM is

hg: jdk8/tl/langtools: 7104201: Refactor DocCommentScanner

2011-11-04 Thread maurizio . cimadamore
Changeset: 56830d5cb5bb Author:mcimadamore Date: 2011-11-04 12:36 + URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/56830d5cb5bb 7104201: Refactor DocCommentScanner Summary: Add new Comment helper class to parse contents of comments in source code Reviewed-by: jjg ! src/

Re: code review request : 7105952: Improve finalisation for FileInputStream/FileOutputStream/RandomAccessFile

2011-11-04 Thread Seán Coffey
ok, so updated webrev at : http://cr.openjdk.java.net/~coffeys/webrev.7105952.2/ some minor modifications : * "closed" variable made private * hg mv instead of rm/add for testcase * testcase padded up some more. * comments changed to block style format in FileDescriptor. * some extra comments a

Timing bugs

2011-11-04 Thread Gary Adams
I've started to look at timing related bugs that have been open for a while, but have not had sufficient priority to make it to the top of the list of bugs to be fixed. Thought I'd start with some low hanging fruit with simple bug fixes. 6731620: TEST_BUG: java/util/Timer/Args.java is too optimi

Race condition in TimerTask KillThread test

2011-11-04 Thread Gary Adams
I'm taking a look at some older timing based bugs that may cause problems on slower machines 6818464: TEST_BUG: Timeout values in several java/util tests are insufficient I'd like to split this bug into two, based on the example problems that are mentioned in the bug report. The first example

Re: Code Review Request for 4533691 (add Collections.EMPTY_SORTED_SET)

2011-11-04 Thread Mike Duigou
On Nov 3 2011, at 17:40 , David Holmes wrote: > Mike, > > I see that you have pushed a version of this change and that I was listed as > a reviewer. However I never saw an updated webrev and there was no response > to my query below. In fact I never saw any response to any of the reviewers >

RE: Code Review Request for 4533691 (add Collections.EMPTY_SORTED_SET)

2011-11-04 Thread Jason Mehrens
Mike, These 'simple' classes are really hard to get right. Here is my review of the change: 1. Why not extend EmptySet? You wouldn't have to implement so many methods. 2. The comparator method is using raw types. 3. The readResolve method comment is just wrong. Create a default access sta

core-libs-dev@openjdk.java.net

2011-11-04 Thread Alan Bateman
On 04/11/2011 12:03, Heiko Wagner wrote: Hi Tom, thanks for your reply. I am using JNI in a different,propably never designed to be used that way, kind of scenario. I use JNI to bring Java to a legacy Smalltalk based product[1]. The Smalltalk code does directly invoke the JNI calls from its own

core-libs-dev@openjdk.java.net

2011-11-04 Thread Naoto Sato
Yep. Please file a bug. Naoto On 11/4/11 12:39 PM, Alan Bateman wrote: As to the ArrayIndexOutOfBoundsException, that does seem to be a bug as I assume that getClassContext is returning an array of one element corresponding to the caller frame (getBundle in this case).

Re: Race condition in TimerTask KillThread test

2011-11-04 Thread Alan Bateman
On 04/11/2011 15:52, Gary Adams wrote: : I'll attempt a simple fix for the KillThread case by replacing : Thread.sleep(100); with a simple loop do { Thread.sleep(100); } while (waiting); where the TimerTask runnable will clear the flag with "waiting = false " onc