RE: Code Review Request for 4533691 (add Collections.EMPTY_SORTED_SET)

2011-11-13 Thread Jason Mehrens
Darryl, >> 2. The comparator method is using raw types. >The SortedSet.comparator() method spec allows returning of null. Right. But, the return type of the implementation is a raw comparator not Comparator defined by the interface. >> 4. Only the IAE if statement is need for your range che

Re: Code Review Request for 6578042

2011-11-13 Thread David Holmes
On 12/11/2011 10:14 PM, Alan Bateman wrote: On 11/11/2011 19:37, Darryl Mocek wrote: Returning null if the value is not a String gives the impression that there was no property with that key when the property may have been there and may in fact have been removed. That's a fair point and probabl

Re: CR 6860309 - solaris timing issue on thread startup

2011-11-13 Thread David Holmes
Alan, On 12/11/2011 9:58 PM, Alan Bateman wrote: On 11/11/2011 16:56, Gary Adams wrote: CR 6860309 - TEST_BUG: Insufficient sleep time in java/lang/Runtime/exec/StreamsSurviveDestroy.java A timing problem is reported for slow solaris systems for this test to start up a process and systematical