Re: Collections.enumeration() WAS Warning Cleanup Day

2011-12-03 Thread Rémi Forax
On 12/03/2011 03:33 PM, Alan Bateman wrote: On 03/12/2011 12:37, Rémi Forax wrote: I've started to remove warnings from java.util and I'm not able to cleanly retrofit java.util.PropertyPermission because java.util.Collections.enumeration is wrongly typed. Rémi - you might want to sync up with M

Re: Collections.enumeration() WAS Warning Cleanup Day

2011-12-03 Thread Mike Duigou
On Dec 3 2011, at 07:12 , Rémi Forax wrote: > On 12/03/2011 03:33 PM, Alan Bateman wrote: >> On 03/12/2011 12:37, Rémi Forax wrote: >>> I've started to remove warnings from java.util >>> and I'm not able to cleanly retrofit java.util.PropertyPermission >>> because java.util.Collections.enumeratio

Re: Collections.enumeration() WAS Warning Cleanup Day

2011-12-03 Thread Rémi Forax
On 12/03/2011 05:21 PM, Mike Duigou wrote: On Dec 3 2011, at 07:12 , Rémi Forax wrote: On 12/03/2011 03:33 PM, Alan Bateman wrote: On 03/12/2011 12:37, Rémi Forax wrote: I've started to remove warnings from java.util and I'm not able to cleanly retrofit java.util.PropertyPermission because ja

review of 7117249: java.util warnings patches from LJC/Mike Barker

2011-12-03 Thread Stuart Marks
[bcc to jdk8-dev; subsequent reviews/comments should go to core-libs-dev] Hi Mike, all, I've collected all the patches together, filed bug 7117249 to cover them, and have started this new review thread on core-libs-dev for it. I've also posted a webrev for the collected patches: http://cr.op

Re: review of 7117249: java.util warnings patches from LJC/Mike Barker

2011-12-03 Thread Alan Bateman
On 03/12/2011 20:59, Stuart Marks wrote: [bcc to jdk8-dev; subsequent reviews/comments should go to core-libs-dev] Hi Mike, all, I've collected all the patches together, filed bug 7117249 to cover them, and have started this new review thread on core-libs-dev for it. I've also posted a webrev

Re: Request for Review: 7116914 (Miscellaneous warnings (sun.text))

2011-12-03 Thread Alan Bateman
On 02/12/2011 21:53, Stuart Marks wrote: Actually the original code is a little odd, as it returns an instance of an anonymous subclass of AttributedCharacterIterator.Attribute, instead of an instance of AttributedCharacterIterator.Attribute itself. I don't if this is right or wrong. s'marks A

Re: review of 7117249: java.util warnings patches from LJC/Mike Barker

2011-12-03 Thread Stuart Marks
On 12/3/11 2:32 PM, Michael Barker wrote: Mike, if you end up needing to update this patch further, it might be easiest if you just sent all the changes in a single patch file, i.e. the output of 'hg diff'. I can then apply it to the tip and generate a webrev quite easily. No problem. I'll dro

Re: review request (L): 7030453: JSR 292 ClassValue.get method is too slow

2011-12-03 Thread John Rose
The caching ClassValue is still under review. I took the opportunity to remove -Xlint warnings (adding type parameters) and refactor for better readability. Also, Mike Duigou pointed out that there was still a dependency on ClassValue.equals == Object.equals, which could create a side-channel b