Re: Code Review - CR# 7030573 insufficient disk space for large file test

2012-01-09 Thread Gary Adams
On 01/ 6/12 03:32 PM, Alan Bateman wrote: On 06/01/2012 19:47, Gary Adams wrote: I've updated the webrev with the temp file created in the current directory. I'm not sure what to do about the case if there is only a little space available only a small file will be used. Should the test fail an

Re: Code Review - CR# 7030573 insufficient disk space for large file test

2012-01-09 Thread Alan Bateman
On 09/01/2012 15:26, Gary Adams wrote: A fresh webrev is available : http://cr.openjdk.java.net/~gadams/7030573/ Includes the following changes - moved temp file create into main - use Math.min for selecting 7G or space available and for skip size - added runtime exception if no

Re: Need reviewer: ant script bug in jaxws

2012-01-09 Thread Kelly O'Hair
On Jan 8, 2012, at 3:35 PM, David Holmes wrote: > Hi Kelly, > > On 7/01/2012 4:35 AM, Kelly O'Hair wrote: >> Still need a reviewer for this small change. Any volunteers? > > Seems okay. Did we determine how they went missing in the first place? A long long time ago, when we did the split of j

Re: Fraction

2012-01-09 Thread Dmitry Nadezhin
Hello Joe, Thank you for the clarification. What do you think about using BigBinary to solve the problem of a calculation class with higher precision. BigBinary implements arbitrary precision binary floating-point numbers and arithmetic operations on them. Although it rounds, the precision and ro

hg: jdk8/tl/jdk: 7030573: test/java/io/FileInputStream/LargeFileAvailable.java fails when there is insufficient disk space

2012-01-09 Thread alan . bateman
Changeset: 74c92c3e66ad Author:gadams Date: 2012-01-09 19:33 + URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/74c92c3e66ad 7030573: test/java/io/FileInputStream/LargeFileAvailable.java fails when there is insufficient disk space Reviewed-by: alanb ! test/java/io/FileInputStre

hg: jdk8/tl/jdk: 7128441: StrictMath performance improvement note shared with Math

2012-01-09 Thread joe . darcy
Changeset: 858038d89fd5 Author:darcy Date: 2012-01-09 15:54 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/858038d89fd5 7128441: StrictMath performance improvement note shared with Math Reviewed-by: darcy Contributed-by: Martin Desruisseaux ! src/share/classes/java/lang/Mat

Re: StrictMath performance improvement not ported to Math?

2012-01-09 Thread Joe Darcy
Hello Martin, Catching up after the holidays, I built a JDK with your patch and all the relevant regression tests passed and I've just pushed the changes to JDK 8's TL integration repository: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/858038d89fd5 Thanks, -Joe On 11/22/2011 1:47 PM, Martin

Request for review: 7123229: (coll) EnumMap.containsValue(null) returns true

2012-01-09 Thread Neil Richards
Hi all, When proposing the change for 6312706 [1], I erroneously managed to convince myself (and others!) that it would be safe to use 'new Integer(0)' for java.util.EnumMap.NULL (the object used to mark null values for entries in the map) [2]. This was on the basis that I thought it was only comp

Code review request for javadoc problem in java.lang.invoke.MethodHandle

2012-01-09 Thread Joe Darcy
Hello, Please review the simple patch below to fix a javadoc problem in java.lang.invoke.MethodHandle which stems from the arguments to the {@link} javadoc tag being reversed. Once reviewed, I'll file a bug for this and push the fix. Thanks, -Joe diff -r 858038d89fd5 src/share/classes/java

Re: Patch to expand tz checking scope in TimeZone_md.c

2012-01-09 Thread Jonathan Lu
Hi core-libs-dev, Here's another approach to just add a defined(AIX) check to make sure it works on Aix platform. http://cr.openjdk.java.net/~luchsh/timezone_md_ret_check/ Any suggestions? Cheers, - Jonathan On 11/02/2011 04:56 PM, Jonathan Lu wrote: Hi core-libs-dev, In jdk/src/solaris/na

Re: Request for review: 7123229: (coll) EnumMap.containsValue(null) returns true

2012-01-09 Thread Mike Duigou
This looks correct. I appreciate the toString() method with a unique result. Mike On Jan 9 2012, at 17:05 , Neil Richards wrote: > Hi all, > When proposing the change for 6312706 [1], I erroneously managed to > convince myself (and others!) that it would be safe to use 'new > Integer(0)' for ja

Re: Code review request for javadoc problem in java.lang.invoke.MethodHandle

2012-01-09 Thread Mike Duigou
+1 On Jan 9 2012, at 18:17 , Joe Darcy wrote: > Hello, > > Please review the simple patch below to fix a javadoc problem in > java.lang.invoke.MethodHandle which stems from the arguments to the {@link} > javadoc tag being reversed. > > Once reviewed, I'll file a bug for this and push the fix.

hg: jdk8/tl/jdk: 7128512: Javadoc typo in java.lang.invoke.MethodHandle

2012-01-09 Thread joe . darcy
Changeset: dd69d3695cee Author:darcy Date: 2012-01-09 20:14 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/dd69d3695cee 7128512: Javadoc typo in java.lang.invoke.MethodHandle Reviewed-by: mduigou ! src/share/classes/java/lang/invoke/MethodHandle.java

Updated unit test for BigInteger patch (#4837946)

2012-01-09 Thread Tim Buktu
I updated BigIntegerTest so it tests the existing multiplication and division algorithms as well as the ones added by my (and Alan's) BigInteger patch. This patch also adds a 6th type of random number to the 5 already present. The new type outputs random numbers that contain long runs of 1-bits an

typo in sun.misc.VM's comment

2012-01-09 Thread Krystal Mok
Hi all, Just found a little typo in sun.misc.VM: diff -r 00e2c88e2234 src/share/classes/sun/misc/VM.java --- a/src/share/classes/sun/misc/VM.java Thu Nov 17 10:46:02 2011 -0800 +++ b/src/share/classes/sun/misc/VM.java Tue Jan 10 13:42:52 2012 +0800 @@ -167,7 +167,7 @@ // // The initial

Re: CFV: New core-libs Group Member: David Holmes

2012-01-09 Thread Peter Jones
Vote: yes -- Peter On Jan 5, 2012, at 8:08 AM, Alan Bateman wrote: > I hereby nominate David Holmes to membership of the core-libs group. > > David doesn't need too much introduction. He is a reviewer on several OpenJDK > projects, including the HotSpot Express project, JDK 7 and JDK 8. He is

Re: CFV: New core-libs Group Member: Brian Goetz

2012-01-09 Thread Peter Jones
Vote: yes -- Peter On Jan 5, 2012, at 7:39 AM, Alan Bateman wrote: > I hereby nominate Brian Goetz to membership of the core-libs group. > > Brian doesn't need too much introduction. He's lead for OpenJDK's Project > Lambda, and while this project is sponsored by the compiler group, is all >

Re: Code review request for javadoc problem in java.lang.invoke.MethodHandle

2012-01-09 Thread John Rose
Yes. Thanks, Joe. -- John On Jan 9, 2012, at 6:17 PM, Joe Darcy wrote: > Please review the simple patch below to fix a javadoc problem in > java.lang.invoke.MethodHandle which stems from the arguments to the {@link} > javadoc tag being reversed.

Re: 100218: BigInteger staticRandom field

2012-01-09 Thread Joe Darcy
Hello, Catching up on email after the holidays... On 01/05/2012 09:58 AM, Doug Lea wrote: On 01/05/12 01:02, Bill Pugh wrote: So I think the right thing to do is to abandon the original patch, and instead make the following changes: * add the following method to BigInteger public boolea