RFR: 7134690: remove legacy jnilib support from ClassLoader and System [macosx]

2012-01-27 Thread Michael McMahon
Can I get the following change reviewed please? The change is to remove some mac specific code from: src/share/classes/java/lang/System.java and src/share/classes/java/lang/ClassLoader.java which added support for non-standard native library suffixes on Mac OS (ie. .jnilib as well as the standar

Re: RFR: 7134690: remove legacy jnilib support from ClassLoader and System [macosx]

2012-01-27 Thread Alan Bateman
On 27/01/2012 11:41, Michael McMahon wrote: Can I get the following change reviewed please? The change is to remove some mac specific code from: src/share/classes/java/lang/System.java and src/share/classes/java/lang/ClassLoader.java which added support for non-standard native library suffixes

Please review: 7127906: (launcher) convert the launcher regression tests to java

2012-01-27 Thread Kumar Srinivasan
Hi Joe, Naoto, Sherman, Here are the highlights of these changes: 1. The TestHelper.java is now extensible, this simplifies the usage of static variables and methods, added a couple of convenience methods and some minor refactoring. 2. Eliminated some shell tests, (few more remaining,

Re: Please review: 7127906: (launcher) convert the launcher regression tests to java

2012-01-27 Thread Joe Darcy
Hi Kumar, Looks fine; good to see the shell code go away! -Joe On 01/27/2012 10:03 AM, Kumar Srinivasan wrote: Hi Joe, Naoto, Sherman, Here are the highlights of these changes: 1. The TestHelper.java is now extensible, this simplifies the usage of static variables and methods, added a

Re: Please review: 7127906: (launcher) convert the launcher regression tests to java

2012-01-27 Thread Naoto Sato
Hi Kumar, I have a question/suggestion on TestHelper.isEnglishLocale field. - Is there any chance that the test case changes the default locale by Locale.setDefault() during the test execution? If that's the case, static initialization of the field may not work. - If the default locale does

Re: Please review: 7127906: (launcher) convert the launcher regression tests to java

2012-01-27 Thread Kumar Srinivasan
On 1/27/2012 11:05 AM, Naoto Sato wrote: Hi Kumar, I have a question/suggestion on TestHelper.isEnglishLocale field. - Is there any chance that the test case changes the default locale by Locale.setDefault() during the test execution? If that's the case, static initialization of the field may

Re: Please review: 7127906: (launcher) convert the launcher regression tests to java

2012-01-27 Thread Naoto Sato
On 1/27/12 11:36 AM, Kumar Srinivasan wrote: On 1/27/2012 11:05 AM, Naoto Sato wrote: Hi Kumar, I have a question/suggestion on TestHelper.isEnglishLocale field. - Is there any chance that the test case changes the default locale by Locale.setDefault() during the test execution? If that's the

Re: Updated unit test for BigInteger patch (#4837946)

2012-01-27 Thread Tim Buktu
On 01/11/2012 11:59 AM, Joe Darcy wrote: > Thanks Tim. I'll add this to my review queue after Alan Eliasen's work > (finally) gets in. Is there a timeframe for this yet?

Review request for 7133220: Additional patches to JAXP 1.4.5 update 1 for 7u4

2012-01-27 Thread Joe Wang
Hi, With this additional patch, I'm fixing a SpecJvm2008 failure against 7u4 b07 (7098746), along with a couple of other fixes and accumulated Xalan update. The changes are listed below and at http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7133220. The webrev is at: http://cr.openjdk.java

hg: jdk8/tl/jdk: 7136538: typo in test/Makefile under the jdk_security3 target

2012-01-27 Thread valerie . peng
Changeset: ff24779c147f Author:valeriep Date: 2012-01-27 15:25 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/ff24779c147f 7136538: typo in test/Makefile under the jdk_security3 target Summary: Fixed the typo of "secrity". Reviewed-by: wetmore ! test/Makefile

Re: Please review: 7127906: (launcher) convert the launcher regression tests to java

2012-01-27 Thread Kumar Srinivasan
Hi Naoto, Here is the incremental webrev since last revision: http://cr.openjdk.java.net/~ksrini/7127906/webrev.1/webrev.delta/index.html Here is the full webrev for reference: http://cr.openjdk.java.net/~ksrini/7127906/webrev.1/index.html Thanks Kumar On 1/27/12 11:36 AM, Kumar Srinivasan w

Re: Please review: 7127906: (launcher) convert the launcher regression tests to java

2012-01-27 Thread Naoto Sato
Looks good to me. Thanks. Naoto On 1/27/12 3:31 PM, Kumar Srinivasan wrote: Hi Naoto, Here is the incremental webrev since last revision: http://cr.openjdk.java.net/~ksrini/7127906/webrev.1/webrev.delta/index.html Here is the full webrev for reference: http://cr.openjdk.java.net/~ksrini/71279