hg: jdk8/tl/jdk: 7120974: ManagementPermission "control" needs clarification

2012-02-01 Thread frederic . parain
Changeset: ac26d04e76c3 Author:fparain Date: 2012-02-01 03:52 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/ac26d04e76c3 7120974: ManagementPermission "control" needs clarification Reviewed-by: mchung, dholmes ! src/share/classes/java/lang/management/ManagementPermission.ja

Re: 7140918: Remove dependency on apt and com.sun.mirror API

2012-02-01 Thread Alan Bateman
On 01/02/2012 15:13, Miroslav Kos wrote: Hi Alan, do you have any update about approving the changeset? The jaxws bundle is already in place, so there should be nothing blocking us from the final step(?) I plan to push it later this week once I've verified the the downloads and done a few test

Review request : 7141141 Add 3 new test scenarios for testing Main-Class attribute in jar manifest file

2012-02-01 Thread Kumar Srinivasan
Hi, Here are some improvements to the launcher tests, contributed by Sonali Goel of the SQE team, please review: http://cr.openjdk.java.net/~ksrini/7141141/webrev.0/ The CR: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7141141 Thanks Kumar

hg: jdk8/tl/jdk: 7141910: Incorrect copyright dates on new test cases.

2012-02-01 Thread bradford . wetmore
Changeset: 55a82eba1986 Author:wetmore Date: 2012-02-01 16:00 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/55a82eba1986 7141910: Incorrect copyright dates on new test cases. Reviewed-by: mullan ! test/sun/security/ssl/com/sun/net/ssl/internal/ssl/EngineArgs/DebugReportsOn

Re: Review request : 7141141 Add 3 new test scenarios for testing Main-Class attribute in jar manifest file

2012-02-01 Thread Joseph Darcy
Hello, On 2/1/2012 1:37 PM, Kumar Srinivasan wrote: Hi, Here are some improvements to the launcher tests, contributed by Sonali Goel of the SQE team, please review: http://cr.openjdk.java.net/~ksrini/7141141/webrev.0/ The CR: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7141141 Thanks

Re: Review request : 7141141 Add 3 new test scenarios for testing Main-Class attribute in jar manifest file

2012-02-01 Thread David Schlosnagle
On Wed, Feb 1, 2012 at 7:46 PM, Joseph Darcy wrote: >  43  * only English is seleced and will pass vacuosly for other locales. Pedantic I know, but can you correct the two spelling mistakes in MainClassAttributeTest.java? s/seleced/selected/ s/vacuosly/vacuously/ 43 * only English is seleced

Re: Review request : 7141141 Add 3 new test scenarios for testing Main-Class attribute in jar manifest file

2012-02-01 Thread Kumar Srinivasan
Hi Joe, David, Thanks for the feedback, here is the modified delta webrev: http://cr.openjdk.java.net/~ksrini/7141141/webrev.1/webrev.delta/index.html Changes are: * Eliminated typos and fixed the comments * Replaced @compile with @build * Replaced Throwable with IOException this makes it consis