Re: Code Review Request: 7157893: Warnings Cleanup in java.util.*

2012-04-06 Thread Rémi Forax
On 04/05/2012 11:04 PM, Stuart Marks wrote: [...] I was going to suggest adding a comment to explain this but I suspect that would make this code even more confusing. just perhaps something saying it's a known limitation of the type-system Yeah, probably something like "need to cast to r

hg: jdk8/tl/langtools: 7157626: Create a new test to check major version for a class file

2012-04-06 Thread jonathan . gibbons
Changeset: 55ae94116e89 Author:jjg Date: 2012-04-06 10:10 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/55ae94116e89 7157626: Create a new test to check major version for a class file Reviewed-by: jjg Contributed-by: sonali.g...@oracle.com + test/tools/javac/classfile

Re: Code Review Request: 7157893: Warnings Cleanup in java.util.*

2012-04-06 Thread Stuart Marks
Hi Kurchi, I think we've converged on the code changes. Please prepare and post another webrev for a final cross-check before pushing. What follows is I think merely residual disagreement over the philosophy of how to handle generic casts vs reification. :-) On 4/6/12 3:06 AM, Rémi Forax wrot

Re: Code Review Request: 7157893: Warnings Cleanup in java.util.*

2012-04-06 Thread Stuart Marks
On 4/5/12 12:08 AM, Stuart Marks wrote: src/share/classes/java/util/PropertyPermission.java -- - L599 this is another case of "laundering" a conversion through a raw type (similar to Collections.java above), as we can't directly