Re: Code Review Request: 7160242: (prefs) Preferences.remove(null) does not throw NPE [macosx]

On 24/04/12 23:44, Rémi Forax wrote: On 04/25/2012 12:20 AM, Kurchi Hazra wrote: Thanks Remi. I changed it: http://cr.openjdk.java.net/~khazra/7160242/webrev.02/ Thumb up. +1. I also really like requireNonNull. To me its less verbose, cleaner, and the intent is easily understood. The jtr

Re: Code Review Request: 7160242: (prefs) Preferences.remove(null) does not throw NPE [macosx]

On 24/04/2012 23:20, Kurchi Hazra wrote: Thanks Remi. I changed it: http://cr.openjdk.java.net/~khazra/7160242/webrev.02/ Can you also point out what advantage using Object.requireNonNull has over simply doing a key == null check as I was doing before? The change looks fine to me; I thought or

A nice cross-locale same-width DateTime.toString()?

Hi All We have a command line tool that needs to print out date/time in a table. The current Date.toString() always has the same width and it's beautiful: 76 Tue Nov 10 08:57:54 CST 2009 bin/vbin/go 1149 Sun Apr 08 16:03:20 CST 2012 bin/vbin/netbeans 170 Fri Nov 20 16:47:42

Re: sun.management.Agent: the properties.putAll API may fail with ConcurrentModifcationException on multi-thread scenario

Deven, CR number is 7164191 . Could you re-send me your original e-mail with problem description and webrev link. I'll put it to CR comment field. -Dmitry On 2012-04-24 16:15, Dmitry Samersoff wrote: > Deven, > > After close look and off-line discussion with David Holmes, > the changes l

Re: Proposed refactoring: introduce JLS7 language features to core libs

Hello, is there any interest to accept change sets based on OpenJDK 7 that update the java classes in jdk/src/share/classes to use * multi-catch * string switch statements as opposed to nested if statements when comparing strings with string literals * type inference by removing duplicative ty

hg: jdk8/tl/jdk: 7160242: (prefs) Preferences.remove(null) does not throw NPE [macosx]

Changeset: 3e398b549cea Author:khazra Date: 2012-04-25 12:31 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/3e398b549cea 7160242: (prefs) Preferences.remove(null) does not throw NPE [macosx] Summary: Insert null check of argument in remove()'s implementation Reviewed-by: fora

Code Review Request: 7118100: Inconsistency when using system and user preference on OSX Lion

Hi, While syncing user preferences, a BackingStoreException is not expected, since the current user should be able to read/write such preferences to the persistent storage (unlike system preferences, where current user needs to have admin rights). This fix aims at allowing a user preference nod

Re: sun.management.Agent: the properties.putAll API may fail with ConcurrentModifcationException on multi-thread scenario

Hi Dmitry, Thanks for your help. I have created a CR with internal id 2236492 which hasn't be published yet. So please set this internal CR id as duplicate to 716419 as well. This is the original mail for this problem: ---