hg: jdk8/tl/jdk: 6996372: synchronizing handshaking hash

2012-04-27 Thread xuelei . fan
Changeset: f0842ed897c3 Author:xuelei Date: 2012-04-27 04:25 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/f0842ed897c3 6996372: synchronizing handshaking hash Summary: remove the unnecessary synchronization. Also reviewed by David Schlosnagle (schlo...@gmail.com) Reviewed-

Re: RFR: 7103570 AtomicIntegerFieldUpdater does not work when SecurityManager is installed

2012-04-27 Thread Doug Lea
On 04/27/12 00:47, David Holmes wrote: Due to a problem with jtreg and the installation of a security manager I've had to modify the test to install the security manager itself. updated webrev: http://cr.openjdk.java.net/~dholmes/7103570/webrev.02/ Looks OK, although the main sources seems t

Re: Remove the assert in Integer.valueOf()

2012-04-27 Thread Ulf Zibis
Am 23.04.2012 19:35, schrieb Rémi Forax: Hi guys, I've found a case where assert is harmful because it doesn't play well with Hotspot inlining heuristic. [...] I think it's a good idea to comment this assert. While you are there: IntegerCache.cache/high/low are static final, so should be named

Re: RFR: 7103570 AtomicIntegerFieldUpdater does not work when SecurityManager is installed

2012-04-27 Thread David Holmes
On 27/04/2012 9:32 PM, Doug Lea wrote: On 04/27/12 00:47, David Holmes wrote: Due to a problem with jtreg and the installation of a security manager I've had to modify the test to install the security manager itself. updated webrev: http://cr.openjdk.java.net/~dholmes/7103570/webrev.02/ Loo

Re: Review Request: 7164376 Replace use of sun.security.action.LoadLibraryAction

2012-04-27 Thread Alan Bateman
On 26/04/2012 19:49, Mandy Chung wrote: 7164376 Replace use of sun.security.action.LoadLibraryAction with direct call of System.loadLibrary Webrev: http://cr.openjdk.java.net/~mchung/jdk8/webrevs/7164376/webrev.00/ This change is required for jdk modularization. I went through the pat

RFR: 5015163 "(str) String merge/join that is the inverse of String.split()" into JDK 8

2012-04-27 Thread Jim Gish
This enhancement proposal has a long history. The most recent attempt to get some String.join() methods was by Joe Darcy back in 2009 ( http://mail.openjdk.java.net/pipermail/core-libs-dev/2009-October/002967.html) He started with the changes that Remi Forax had done 8 months prior to that,

Re: Remove the assert in Integer.valueOf()

2012-04-27 Thread Rémi Forax
On 04/27/2012 05:29 AM, Joe Darcy wrote: On 4/24/2012 8:01 AM, Alan Bateman wrote: On 24/04/2012 14:56, Rémi Forax wrote: Here, I don't really ask for tweaking something but more to remove an assert which do something which is unrelated to the current algorithm. In my opinion, it's a debug a

Re: Remove the assert in Integer.valueOf()

2012-04-27 Thread Rémi Forax
On 04/27/2012 02:14 PM, Ulf Zibis wrote: Am 23.04.2012 19:35, schrieb Rémi Forax: Hi guys, I've found a case where assert is harmful because it doesn't play well with Hotspot inlining heuristic. [...] I think it's a good idea to comment this assert. Hi Ulf, While you are there: IntegerCach

Re: RFR: 5015163 "(str) String merge/join that is the inverse of String.split()" into JDK 8

2012-04-27 Thread Rémi Forax
Hi Jim, Yes, I've basically try to submit a patch each time I've written a method join in one of my application :) The funny think (in fact it's even not funny) is that I think that this methods should not be in String anymore. In Java 8, we will have defender methods so you can write join di

Re: Remove the assert in Integer.valueOf()

2012-04-27 Thread Joseph Darcy
Hi Remi, On 4/27/2012 3:38 PM, Rémi Forax wrote: On 04/27/2012 05:29 AM, Joe Darcy wrote: On 4/24/2012 8:01 AM, Alan Bateman wrote: On 24/04/2012 14:56, Rémi Forax wrote: Here, I don't really ask for tweaking something but more to remove an assert which do something which is unrelated to t