hg: jdk8/tl/jdk: 7163470: Build fails if javax.crypto src files not present

2012-05-10 Thread sean . coffey
Changeset: fdf5e15293e6 Author:coffeys Date: 2012-05-10 10:45 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/fdf5e15293e6 7163470: Build fails if javax.crypto src files not present Reviewed-by: valeriep ! make/com/oracle/security/ucrypto/Makefile ! make/common/shared/Defs-ja

hg: jdk8/tl/jdk: 3 new changesets

2012-05-10 Thread valerie . peng
Changeset: 3e3017eba8ac Author:valeriep Date: 2012-05-08 17:57 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/3e3017eba8ac 4963723: Implement SHA-224 Summary: Add support for SHA-224, SHA224withRSA, SHA224withECDSA, HmacSHA224 and OAEPwithSHA-224AndMGF1Padding. Reviewed-by:

Re: review request: 4244896: (process) Provide System.getPid(), System.killProcess(String pid)

2012-05-10 Thread Rob McKenna
Hi folks, The latest version is at: http://cr.openjdk.java.net/~robm/4244896/webrev.03/ Feedback greatly appreciated. -Rob On 19/04/12 12:05, Alan Bateman wrote: On 19/04/2012 01:05, David Holmes wrote: On 18/04/2012 11:44 PM, Ja

hg: jdk8/tl/langtools: 7159445: (javac) emits inaccurate diagnostics for enhanced for-loops

2012-05-10 Thread kumar . x . srinivasan
Changeset: 833bab705918 Author:ksrini Date: 2012-05-10 12:32 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/833bab705918 7159445: (javac) emits inaccurate diagnostics for enhanced for-loops Reviewed-by: jjg Contributed-by: jan.lah...@oracle.com ! src/share/classes/com/

Re: Review Request for CR : 7144861 RMI activation tests are too slow

2012-05-10 Thread Olivier Lagneau
Please find the second webrev with your remarks applied here: http://cr.openjdk.java.net/~olagneau/7144861/webrev.01/ In addition to the way we have agreed (see below) to handle InterruptedException in this fix, I have applied all the other requests for change. Regarding RMID.start() with outer

Re: Review Request for CR : 7144861 RMI activation tests are too slow

2012-05-10 Thread Olivier Lagneau
Olivier Lagneau said on date 5/11/2012 12:13 AM: Please find the second webrev with your remarks applied here: http://cr.openjdk.java.net/~olagneau/7144861/webrev.01/ In addition to the way we have agreed (see below) to handle InterruptedException in this fix, I have applied all the other req

Re: Review Request for CR : 7144861 RMI activation tests are too slow (wrong webev link fixed)

2012-05-10 Thread Olivier Lagneau
Olivier Lagneau said on date 5/11/2012 12:13 AM: Please find the second webrev with your remarks applied here: http://cr.openjdk.java.net/~olagneau/7144861/webrev.01/ Html link above is buggy. Please go to this correct location: http://cr.openjdk.java.net/~olagneau/7144861/webrev.01 In ad

Review Request : 7071826 : Avoid benign race condition in initialization of UUID

2012-05-10 Thread Mike Duigou
Hello all; A benign but potentially expensive race condition was discovered in java.util.UUID. The initialization of numberGenerator may cause the creation of a number of SecureRandom instances if multiple threads are attempting to initialize the field at the same time. This can happen because

Re: Review Request for CR : 7144861 RMI activation tests are too slow (wrong webev link fixed)

2012-05-10 Thread Stuart Marks
Looks good. Just one thing: in JavaVM.java, the declaration line for "boolean started" still has a comment that says "updated by started() method". That method has been renamed to setStarted(). Either fix the comment or perhaps better, remove it entirely. It's pretty easy to find uses of private

Re: Review Request for CR : 7144861 RMI activation tests are too slow (wrong webev link fixed)

2012-05-10 Thread David Holmes
IE handling seems fine. No further comments from me. Note I was not a full reviewer of this. David On 11/05/2012 11:04 AM, Stuart Marks wrote: Looks good. Just one thing: in JavaVM.java, the declaration line for "boolean started" still has a comment that says "updated by started() method". Tha