Re: Code Review Request: 7173645: (props) System.getProperty("os.name") should return "Windows Server 2012" for Windows Server 2012

2012-06-06 Thread Chris Hegarty
Looks fine. -Chris. On 05/06/2012 19:36, Kurchi Hazra wrote: Hi, This is a minor change in java_props_md.c to return "Windows Server 2012" as the "os.name" when running on Windows Server 2012. Bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7173645 (To appear soon) Webrev: http://cr.o

Re: non-blocking channel Infinite loop in java.util.Scanner

2012-06-06 Thread Alan Bateman
On 06/06/2012 00:12, Rémi Forax wrote: Thanks Alan, I can't ensure that the blocking mode will not change by synchronizing on the channel's blockingLock because I will have to take the lock before creating the reader and releasing it when the reader is closed. Looking at now, it would need to

Re: [PATCH] 7164256 : EnumMap.clone doesn't clear the entrySet field, keeping a reference to the original Map

2012-06-06 Thread Alan Bateman
This looks good to me and I'm happy to sponsor this. Does anyone else want to review this? -Alan On 29/05/2012 03:37, Diego Belfer wrote: : # HG changeset patch # User muralx # Date 1338257674 10800 # Node ID f61b94fd7aca738353177fcf3cc3972ddf36cf36 # Parent 9b8c96f96a0f9a5801b55530a387fe

Re: [PATCH] 7164256 : EnumMap.clone doesn't clear the entrySet field, keeping a reference to the original Map

2012-06-06 Thread Chris Hegarty
On 06/06/2012 13:28, Alan Bateman wrote: This looks good to me and I'm happy to sponsor this. Does anyone else want to review this? The changes look fine to me too. -Chris. -Alan On 29/05/2012 03:37, Diego Belfer wrote: : # HG changeset patch # User muralx # Date 1338257674 10800 # Nod

Re: [PATCH] 7164256 : EnumMap.clone doesn't clear the entrySet field, keeping a reference to the original Map

2012-06-06 Thread Remi Forax
Yes, looks good to me too. Cheers, Rémi - Reply message - From: "Chris Hegarty" To: "Alan Bateman" Cc: Subject: [PATCH] 7164256 : EnumMap.clone doesn't clear the entrySet field, keeping a reference to the original Map Date: Wed, Jun 6, 2012 14:35 On 06/06/2012 13:28, Alan Batem

An Alternative Hashing Alternative

2012-06-06 Thread Doug Lea
I just posted the following to the concurrency-interest list. I'll send a follow-up on tie-ins to core-lib issues next. ... Finally acting on an old idea, I committed an update to ConcurrentHashMap (currently only the one in our jdk8 preview package, as jsr166e.ConcurrentHashMap8) that much mo

Re: An Alternative Hashing Alternative

2012-06-06 Thread Bob Lee
Whoa! This is awesome. Bob On Wed, Jun 6, 2012 at 9:22 AM, Doug Lea wrote: > > I just posted the following to the concurrency-interest list. > I'll send a follow-up on tie-ins to core-lib issues next. > > ... > > > Finally acting on an old idea, I committed an update to > ConcurrentHashMap (cur

Re: An Alternative Hashing Alternative

2012-06-06 Thread Doug Lea
On 06/06/12 12:22, Doug Lea wrote: I just posted the following to the concurrency-interest list. I'll send a follow-up on tie-ins to core-lib issues next. The main issue is whether adding generic overflow-handling techniques to hash table classes (as used here for ConcurrentHashMap, but variat

hg: jdk8/tl/jdk: 7172826: (se) Selector based on the Solaris event port mechanism

2012-06-06 Thread alan . bateman
Changeset: 119c9a306a3d Author:alanb Date: 2012-06-06 17:59 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/119c9a306a3d 7172826: (se) Selector based on the Solaris event port mechanism Reviewed-by: coffeys, chegar ! make/java/nio/Makefile ! make/java/nio/mapfile-linux ! make

Re: An Alternative Hashing Alternative

2012-06-06 Thread Rémi Forax
I haven't read the whole code (I need a blackboard :) I wonder if it's not better to use unsafe.tryMonitorEnter() instead of a lock bit. Also the class depends on LongAdder, is it a requirement or an AtomicLongUpdater can be used ? cheers, Rémi On 06/06/2012 06:51 PM, Doug Lea wrote: On 06/0

Re: An Alternative Hashing Alternative

2012-06-06 Thread Doug Lea
On 06/06/12 13:09, Rémi Forax wrote: I haven't read the whole code (I need a blackboard :) (The mostly-non-blocking retries here lead to a lot of code sprawl. Macros would help :-) I wonder if it's not better to use unsafe.tryMonitorEnter() instead of a lock bit. I need a lock with a form o

Re: [PATCH] 7164256 : EnumMap.clone doesn't clear the entrySet field, keeping a reference to the original Map

2012-06-06 Thread Mike Duigou
Looks good to me as well. Mike On Jun 6 2012, at 07:47 , Remi Forax wrote: > Yes, looks good to me too. > > Cheers, > Rémi > > - Reply message - > From: "Chris Hegarty" > To: "Alan Bateman" > Cc: > Subject: [PATCH] 7164256 : EnumMap.clone doesn't clear the entrySet field, > keep

hg: jdk8/tl/jdk: 7173645: (props) System.getProperty("os.name") should return "Windows Server 2012" for Windows Server 2012

2012-06-06 Thread kurchi . subhra . hazra
Changeset: af313ded4ffb Author:khazra Date: 2012-06-06 11:37 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/af313ded4ffb 7173645: (props) System.getProperty("os.name") should return "Windows Server 2012" for Windows Server 2012 Summary: Enable Windows Server 2012 to be recog

Re: An Alternative Hashing Alternative

2012-06-06 Thread Rémi Forax
On 06/06/2012 07:23 PM, Doug Lea wrote: On 06/06/12 13:09, Rémi Forax wrote: I haven't read the whole code (I need a blackboard :) (The mostly-non-blocking retries here lead to a lot of code sprawl. Macros would help :-) I wonder if it's not better to use unsafe.tryMonitorEnter() instead of

Re: An Alternative Hashing Alternative

2012-06-06 Thread Doug Lea
On 06/06/12 15:03, Rémi Forax wrote: tryMonitorEnter is the equivalent of tryLock for synchronized block (monitorEnter/monitorExit). Sorry; yes. This method exists, but seems to be designed to only be used in unusual situations. So the performance is dreadful on JVMs I've tried it on. Working o

Re: An Alternative Hashing Alternative

2012-06-06 Thread Rémi Forax
On 06/06/2012 09:09 PM, Doug Lea wrote: On 06/06/12 15:03, Rémi Forax wrote: tryMonitorEnter is the equivalent of tryLock for synchronized block (monitorEnter/monitorExit). Sorry; yes. This method exists, but seems to be designed to only be used in unusual situations. So the performance is dre

hg: jdk8/tl/jdk: 7174244: NPE in Krb5ProxyImpl.getServerKeys()

2012-06-06 Thread xuelei . fan
Changeset: f8e72d7ff37d Author:xuelei Date: 2012-06-06 18:18 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/f8e72d7ff37d 7174244: NPE in Krb5ProxyImpl.getServerKeys() Reviewed-by: weijun ! src/share/classes/sun/security/ssl/SSLContextImpl.java ! src/share/classes/sun/securit

hg: jdk8/tl/jdk: 7172149: ArrayIndexOutOfBoundsException from Signature.verify

2012-06-06 Thread xuelei . fan
Changeset: 713b10821c3d Author:xuelei Date: 2012-06-06 18:39 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/713b10821c3d 7172149: ArrayIndexOutOfBoundsException from Signature.verify Summary: take care of integer addition overflow Reviewed-by: xuelei, wetmore Contributed-by:

hg: jdk8/tl/jdk: 2 new changesets

2012-06-06 Thread daniel . daugherty
Changeset: 181175887d24 Author:jonas Date: 2012-06-06 13:16 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/181175887d24 7174861: all/OPT jdk build on Solaris with FDS enabled sets wrong options Summary: Use CFLAGS_COMMON instead of CC_OPT and CXXFLAGS_COMMON instead of CXX_O