Re: Time format in jar and jarsigner output (was Re: Code review request: 7163483 JarSigner -verify -verbose does not format date string according to locale)

2012-07-11 Thread Xueming Shen
As Max point out, you definitely need to avoid creating SDF everytime you have to print out one entry. But I'm more worried about the fact you are changing the out put of jar t. Jar is a widely used tool, It might be a surprise to someone who has code depend on the current output format. Perso

Re: Native zlib libraries

2012-07-11 Thread Alan Bateman
On 05/07/2012 17:11, Andrew Hughes wrote: - Original Message - Is there a way to get the native zlib libraries to get picked up instead of the hardcoded version within the JVM? -- Azeem Jiva @javawithjiva We have this in IcedTea (USE_SYSTEM_ZLIB=true) and intend to get it upstream. H

Re: [8] Review request for 7162111 change tests run in headless mode [macosx]

2012-07-11 Thread Alan Bateman
On 02/07/2012 15:18, Jason Uh wrote: Anthony and Alan, Thanks for your comments. I've reverted the changes to CommonSetup.sh so that XToolkit is no longer forced. Tests still pass. Please see the new webrev: http://cr.openjdk.java.net/~juh/7162111/webrev.01/ Thanks, Jason This looks okay t

Re: Time format in jar and jarsigner output (was Re: Code review request: 7163483 JarSigner -verify -verbose does not format date string according to locale)

2012-07-11 Thread Jonathan Lu
Hello Sherman, Thanks a lot for review! I've made another patch to no include the changes for jar tool, http://cr.openjdk.java.net/~luchsh/7163483_6/ And to Max, Does it make sense for you to change jarSigner only? best regards! Jonathan On 07/11/2012 03:13 PM, Xueming Shen wrote: As Max

Re: Code Review Request 7142596: RMI JPRT tests are failing

2012-07-11 Thread Alan Bateman
On 06/07/2012 19:47, Stuart Marks wrote: : *** LookupNameWithColon.java This test is missing an @run tag, thus it won't actually get run! Since you've specified an @build tag, you have to specify a separate @run tag to run the test. It's possible to deduce this with a careful reading of th

Re: Native zlib libraries

2012-07-11 Thread Xueming Shen
The zip64 support (total_in/out) part probably can be done at Java level (ignore the total_in/out in z_tream_s). Need to remove this dependency. Will take a look later. -Sherman On 7/11/2012 12:47 AM, Alan Bateman wrote: On 05/07/2012 17:11, Andrew Hughes wrote: - Original Message

Re: Code Review Request 7142596: RMI JPRT tests are failing

2012-07-11 Thread Alan Bateman
On 05/07/2012 22:22, Darryl Mocek wrote: Hello core-libs. Please review this webrev to fix Bugs #7142596 and 7161503. Webrev can be found here: http://cr.openjdk.java.net/~dmocek/7142596/webrev.02. This commit fixes concurrency issues with the RMI tests. - Added TestLibrary.createRegistryOn

Re: Time format in jar and jarsigner output (was Re: Code review request: 7163483 JarSigner -verify -verbose does not format date string according to locale)

2012-07-11 Thread Weijun Wang
On 07/11/2012 03:56 PM, Jonathan Lu wrote: Hello Sherman, Thanks a lot for review! I've made another patch to no include the changes for jar tool, http://cr.openjdk.java.net/~luchsh/7163483_6/ And to Max, Does it make sense for you to change jarSigner only? I don't think so. My understan

hg: jdk8/tl/jdk: 6966259: Make PrincipalName and Realm immutable

2012-07-11 Thread weijun . wang
Changeset: 79b63e8eceda Author:weijun Date: 2012-07-11 17:10 +0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/79b63e8eceda 6966259: Make PrincipalName and Realm immutable Reviewed-by: xuelei ! src/share/classes/javax/security/auth/kerberos/KerberosPrincipal.java ! src/share/cl

Re: Request for review : 7181793 FileDescriptor keeps its own hard reference to Closeables causing a memory leak

2012-07-11 Thread Alan Bateman
On 10/07/2012 17:37, Seán Coffey wrote: 7105952 fix introduced some improvements for finalization strategy around FileInputStream/FileOutputStream/RandomAccessFile. However a recently reported issue has highlighted an issue where memory heap can be consumed with SocketOutputStream objects as

Re: Request for review : 7181793 FileDescriptor keeps its own hard reference to Closeables causing a memory leak

2012-07-11 Thread Seán Coffey
As regards 7u6 then changing java.net.Socket is too risky to do this late in the release so I agree with your proposal to back-out 7105952. It's probably best to create a separate bug for this so that the history is easy to understand. We can then use 7181793 to fix java.net.Socket in jdk8 (

Re: classlist.* and jar_reorder ?

2012-07-11 Thread Alan Bateman
On 03/07/2012 07:54, David Holmes wrote: Can someone explain to me, or point me to docs, regarding the make/tools/sharing/classlist.* files, how they are used and maintained and what jar_reorder does with them? Thanks, David There's a README in make/tools/sharing that outlines how the lists ar

Re: Code Review Request: 7160252: (prefs) NodeAddedEvent was not delivered when new node add when new Node

2012-07-11 Thread Alan Bateman
On 26/06/2012 22:57, Kurchi Hazra wrote: Hi, On Mac OS X, for Preferences, a new child added event was not being delivered to a NodeChangeListener since the existing code depended on the return value of addNode() in the native code, which returns true if a new node is added. However, since

Request for approval for bug# 7177216 - native2ascii changes file permissions of input file

2012-07-11 Thread Mala Bankal
HI, Request approval for : 7177216 - native2ascii changes file permissions of input file for 6-open webrev : http://cr.openjdk.java.net/~mbankal/7177216/webrev.00/ This webrev fixes bug# 7177216 (regression reported in jdk6u33.) Native2ascii tool changes permission of file. Caused due to 714360

Request for approval for bug# 7175845 - "jar uf" changes file permissions unexpectedly

2012-07-11 Thread Mala Bankal
HI, Request approval for : 7175845 - "jar uf" changes file permissions unexpectedly for 6-open webrev : http://cr.openjdk.java.net/~mbankal/7175845/webrev.00/ This webrev fixes bug# 7175845 (regression reported in jdk6u33.) Jar command changes permission of file. Caused due to 7143606. sun.misc

Re: Code Review Request (7161503 subcase) 7142596: RMI JPRT tests are failing

2012-07-11 Thread Olivier Lagneau
Stuart Marks said on date 7/10/2012 10:52 PM: On 7/9/12 11:56 PM, Olivier Lagneau wrote: Le 10/07/2012 08:49, Olivier Lagneau a écrit : Now in the 7161503 SetChilEnv case: I think we should just revert to the existing code regarding the DebugExecWatcher and related exception cleanup fix. We

Re: Code Review Request (7161503 subcase) 7142596: RMI JPRT tests are failing

2012-07-11 Thread Olivier Lagneau
Darryl Mocek said on date 7/10/2012 11:17 PM: I think pushing what we have now and doing the cleanup after to get the RMI test changes in is the best approach. I am ok with that approach Darryl. Olivier. Darryl On 07/10/2012 01:52 PM, Stuart Marks wrote: On 7/9/12 11:56 PM, Olivier Lagneau

[PATCH] Sunbug 7131192: Optimize BigInteger.doubleValue(), floatValue()

2012-07-11 Thread Louis Wasserman
Not entirely sure I'm posting this in the right place, but it looks like it... This is a patch to optimize BigInteger.doubleValue() and floatValue(), which are both currently implemented by converting to a string and back. Doing it with bit-twiddling and Double.longBitsToDouble improves the speed

Re: Code Review Request: 7160252: (prefs) NodeAddedEvent was not delivered when new node add when new Node

2012-07-11 Thread Kurchi Hazra
Thanks for the review Alan. Updated webrev: http://cr.openjdk.java.net/~khazra/7160252/webrev.01/ - Kurchi On 7/11/12 5:45 AM, Alan Bateman wrote: On 26/06/2012 22:57, Kurchi Hazra wrote: Hi, On Mac OS X, for Preferences, a new child added event was not being delivered to a NodeChangeLis

Re: Code Review Request: 7160252: (prefs) NodeAddedEvent was not delivered when new node add when new Node

2012-07-11 Thread Chris Hegarty
On 12 Jul 2012, at 00:15, Kurchi Hazra wrote: > Thanks for the review Alan. Updated webrev: > http://cr.openjdk.java.net/~khazra/7160252/webrev.01/ Looks fine. Trivially, is there an opportunity to make any fields final since initFields is replaced with a constructor? -Chris. > > - Kurchi

Re: Code Review Request: 7160252: (prefs) NodeAddedEvent was not delivered when new node add when new Node

2012-07-11 Thread Kurchi Hazra
On 7/11/12 4:24 PM, Chris Hegarty wrote: On 12 Jul 2012, at 00:15, Kurchi Hazra wrote: Thanks for the review Alan. Updated webrev: http://cr.openjdk.java.net/~khazra/7160252/webrev.01/ Looks fine. Trivially, is there an opportunity to make any fields final since initFields is replaced with

Re: Code Review Request: 7160252: (prefs) NodeAddedEvent was not delivered when new node add when new Node

2012-07-11 Thread Chris Hegarty
Thanks Kurchi, looks fine. -Chris Kurchi Hazra wrote: >On 7/11/12 4:24 PM, Chris Hegarty wrote: >> On 12 Jul 2012, at 00:15, Kurchi Hazra >> wrote: >> >>> Thanks for the review Alan. Updated webrev: >>> http://cr.openjdk.java.net/~khazra/7160252/webrev.01/ >> Looks fine. >> >> Trivially, is t

Re: [PATCH] Sunbug 7131192: Optimize BigInteger.doubleValue(), floatValue()

2012-07-11 Thread Andrew Haley
On 07/11/2012 11:05 PM, Louis Wasserman wrote: > Doing it with bit-twiddling and Double.longBitsToDouble improves the speed > of those methods by something like two orders of magnitude in my benchmarks. Mmm, but that's going to hit double-rounding bugs for large numbers. Where is this patch, anyw