java_props_md.c allocates a 64 byte buffer for the return value of setlocale
on the stack. However, there appears to be no set limit on the return value:
http://pubs.opengroup.org/onlinepubs/009604499/functions/setlocale.html
and no check in the code to ensure that its length is 63 characters or
On 01/08/2012 12:40, Andrew Hughes wrote:
java_props_md.c allocates a 64 byte buffer for the return value of setlocale
on the stack. However, there appears to be no set limit on the return value:
http://pubs.opengroup.org/onlinepubs/009604499/functions/setlocale.html
and no check in the code t
- Original Message -
> On 01/08/2012 12:40, Andrew Hughes wrote:
> > java_props_md.c allocates a 64 byte buffer for the return value of
> > setlocale
> > on the stack. However, there appears to be no set limit on the
> > return value:
> >
> > http://pubs.opengroup.org/onlinepubs/00960449
Changeset: 21c590fdc8cb
Author:mullan
Date: 2012-08-01 11:06 -0400
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/21c590fdc8cb
7179715: OCSP revocation checking fails if the signer certificate is identified
using the key ID
Reviewed-by: vinnie
! src/share/classes/sun/security/pro
Changeset: 184da100cf45
Author:jgish
Date: 2012-07-27 16:17 -0400
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/184da100cf45
6914123: (str) Missing synchronization in
java.lang.String#contentEquals(CharSequence)
Summary: Change contentEquals( CharSequence cs ) to do synchronizati
Hi Andrew,
No, I'm NOT against to fix this "potential" risk at all. Just tried to
point out that this
might not be an "immediate" breach.
It was a mistake to drop the list.
-Sherman
On 08/01/2012 01:11 PM, Andrew Hughes wrote:
- Original Message -
On 08/01/2012 06:52 AM, Andrew Hug
- Original Message -
> Hi Andrew,
>
> No, I'm NOT against to fix this "potential" risk at all. Just tried
> to
> point out that this
> might not be an "immediate" breach.
>
Oh, I know. Just might be nice to get the patch in after four years :-)
> It was a mistake to drop the list.
>
On 08/01/2012 09:52 AM, Andrew Hughes wrote:
> I have no idea what happened with Omair's
> extended version. It's not in IcedTea.
>
I didn't commit it to icedtea since I assumed I would be committing it
to OpenJDK7/8 anyway (and icedtea would get it on the next sync). And I
didn't commit it to O
On 01/08/2012 14:52, Andrew Hughes wrote:
:
In any case, there is a Sun bug open for this:
6844255: Potential stack corruption in GetJavaProperties
Can I take it that I can just get on and push Omair's extended version now then,
with that bug ID?
Yes, go ahead, I should have said that in my
Changeset: 75bda37d0337
Author:omajid
Date: 2012-08-01 22:13 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/75bda37d0337
6844255: Potential stack corruption in GetJavaProperties
Summary: Use dynamically allocated buffers for temp and encoding.
Reviewed-by: alanb, andrew
! sr
- Original Message -
> On 01/08/2012 14:52, Andrew Hughes wrote:
> > :
> >
> >
> > In any case, there is a Sun bug open for this:
> >
> > 6844255: Potential stack corruption in GetJavaProperties
> >
> > Can I take it that I can just get on and push Omair's extended
> > version now then,
>
- Original Message -
> On 08/01/2012 09:52 AM, Andrew Hughes wrote:
> > I have no idea what happened with Omair's
> > extended version. It's not in IcedTea.
> >
>
> I didn't commit it to icedtea since I assumed I would be committing
> it
> to OpenJDK7/8 anyway (and icedtea would get it
Andrew et al,
AFAICS here:
220 encoding_variant = malloc(strlen(temp)+1);
221 if (encoding_variant == NULL) {
222 JNU_ThrowOutOfMemoryError(env, NULL);
223 return 0;
224 }
we also need to do free(temp). Similarly later where we return wi
On 7/30/12 4:43 PM, David Holmes wrote:
On 31/07/2012 8:27 AM, Darryl Mocek wrote:
Hello core-libs. Please review this webrev to fix Bug #7187876. Webrev
can be found here: http://cr.openjdk.java.net/~dmocek/7187876/webrev.00.
The rmi/transport/acceptLoop/CloseServerSocketOnTermination.java tes
Hi Stuart,
On 2/08/2012 12:19 PM, Stuart Marks wrote:
On 7/30/12 4:43 PM, David Holmes wrote:
On 31/07/2012 8:27 AM, Darryl Mocek wrote:
Hello core-libs. Please review this webrev to fix Bug #7187876. Webrev
can be found here: http://cr.openjdk.java.net/~dmocek/7187876/webrev.00.
The rmi/tran
On 8/1/12 8:05 PM, David Holmes wrote:
This case is kind of pathological. The CloseServerSocketOnTermination
test injects an exception of an arbitrary type into the accept loop of
an RMI connection. (See the test to see how it does this; it's rather
clever.) The cast error occurs when the excepti
16 matches
Mail list logo
