Re: Review Request: 7193339 Prepare system classes be defined by a non-null module loader

2012-08-27 Thread Paul Sandoz
On Aug 25, 2012, at 12:57 AM, Mandy Chung wrote: > On 8/24/2012 3:44 PM, David Holmes wrote: >> My other query with these changes is whether we are certain that using the >> specified loader rather than the boot loader will always be correct. > > Yes I'm to my best knowledge but I'm looking t

Re: A bug in filesystem bootstrap (unix/ linux) prevents

2012-08-27 Thread Ulf Zibis
Hi Sherman, what is "jnu" standing for? You have touched on 3 "classes" of system encodings: - default encoding of the file content - the encoding of the file path - the "text" encoding when use the platform APIs Are there more? > so in theory file.encoding should be used to only for the encod

Re: Review Request: 7193406 - Clean-up JDK Build Warnings in java.util, java.io

2012-08-27 Thread Doug Lea
Vitaly Davidovich wrote: I figured you did, but wanted to check. :) So the perf hit was with c2 compilation? Were you able to check the assembly (or enable inlining printing in hotspot) and see that lack of inlining (and whatever further opto that enabled) was the difference by simply adding

Re: RFR [JDK8]: 7169894: JAXP Plugability Layer: using service loader

2012-08-27 Thread Alan Bateman
On 24/08/2012 17:52, Joe Wang wrote: Hi, Here is a modified patch: http://cr.openjdk.java.net/~joehw/jdk8/7169894/webrev/ The factory finders contain some format changes, a NetBeans format work. The real changes are as the follows: 1) In factory classes: reinstated the implementation reso

Re: RFR [JDK8]: 7169894: JAXP Plugability Layer: using service loader

2012-08-27 Thread Paul Sandoz
Hi Joe, This is starting to look cleaner. -- datatype/FactoryFinder.java: 244 } catch (ServiceConfigurationError e) { 245 throw new DatatypeConfigurationException(e.getMessage(), e.getCause()); You are munging the message of the exception and it's cause. Perhaps it would

hg: jdk8/tl/langtools: 7192068: (javac) provide a way for IDEs to produce Enclosing Method attributes.

2012-08-27 Thread kumar . x . srinivasan
Changeset: c9749226cdde Author:ksrini Date: 2012-08-27 07:21 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/c9749226cdde 7192068: (javac) provide a way for IDEs to produce Enclosing Method attributes. Reviewed-by: jjg Contributed-by: [email protected] ! src/share/c

hg: jdk8/tl/corba: 3 new changesets

2012-08-27 Thread lana . steuck
Changeset: 63aeb7a2472f Author:katleman Date: 2012-08-16 11:43 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/corba/rev/63aeb7a2472f Added tag jdk8-b52 for changeset 80689ff9cb49 ! .hgtags Changeset: 16c82fc74695 Author:katleman Date: 2012-08-23 12:27 -0700 URL: http

hg: jdk8/tl/jaxws: 2 new changesets

2012-08-27 Thread lana . steuck
Changeset: 8a35fd644d3c Author:katleman Date: 2012-08-16 11:43 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jaxws/rev/8a35fd644d3c Added tag jdk8-b52 for changeset f62bc618122e ! .hgtags Changeset: 91970935926a Author:katleman Date: 2012-08-23 12:27 -0700 URL: http

hg: jdk8/tl/langtools: 3 new changesets

2012-08-27 Thread lana . steuck
Changeset: d3d0b9cd76e0 Author:katleman Date: 2012-08-16 11:43 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/d3d0b9cd76e0 Added tag jdk8-b52 for changeset 1d2db0e5eabc ! .hgtags Changeset: 9cf72631baf5 Author:katleman Date: 2012-08-23 12:27 -0700 URL:

hg: jdk8/tl/jaxp: 3 new changesets

2012-08-27 Thread lana . steuck
Changeset: 2c566f25c39f Author:katleman Date: 2012-08-16 11:43 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jaxp/rev/2c566f25c39f Added tag jdk8-b52 for changeset bd3c00d57614 ! .hgtags Changeset: 7dd81ccb7c11 Author:katleman Date: 2012-08-23 12:27 -0700 URL: http:

hg: jdk8/tl/hotspot: 12 new changesets

2012-08-27 Thread lana . steuck
Changeset: ef437ea56651 Author:amurillo Date: 2012-08-03 13:24 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/ef437ea56651 7189086: new hotspot build - hs24-b20 Reviewed-by: jcoomes ! make/hotspot_version Changeset: 1d7922586cf6 Author:twisti Date: 2012-07-24 1

hg: jdk8/tl/jdk: 14 new changesets

2012-08-27 Thread lana . steuck
Changeset: 05e5ce861a58 Author:jrose Date: 2012-07-12 00:10 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/05e5ce861a58 7153157: ClassValue.get does not return if computeValue calls remove Summary: Track intermediate states more precisely, according to spec. Reviewed-by: twis

Review Request: 7193710 ByteArrayOutputStream Javadoc contains unclosed element

2012-08-27 Thread Dan Xu
This change is to fix the java doc font issue for ByteArrayOutputStream class. In current javadoc, contents change to the wrong font starting from toString(String charsetName) in ByteArrayOutputStream.html, which can be viewed at http://docs.oracle.com/javase/7/docs/api/java/io/ByteArrayOutputS

Re: Review Request: 7193406 - Clean-up JDK Build Warnings in java.util, java.io

2012-08-27 Thread Stuart Marks
On 8/27/12 3:55 AM, Doug Lea wrote: The underlying issue is that code size is one of the criteria that JITs use to decide to compile/inline etc. So long as they do so, there will be cases here and there where it critically important to keep sizes small in bottleneck code. Not many, but still enou

Re: Review Request: 7193710 ByteArrayOutputStream Javadoc contains unclosed element

2012-08-27 Thread David Holmes
Hi Dan, On 28/08/2012 6:48 AM, Dan Xu wrote: This change is to fix the java doc font issue for ByteArrayOutputStream class. In current javadoc, contents change to the wrong font starting from toString(String charsetName) in ByteArrayOutputStream.html, which can be viewed at http://docs.oracle.co

[7u8] Request for approval: 7160252: (prefs) NodeAddedEvent was not delivered when new node add when new Node

2012-08-27 Thread Kurchi Hazra
This is a request for approval to backport the fix for 7160252 from 8 to 7u8. Bug:http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7160252 Webrev:http://cr.openjdk.java.net/~khazra/7160252/7u8/webrev.00/ This had been reviewed by Alan Bateman and Chris Hegarty. [1] This fix has been pushed i

Re: [7u8] Request for approval: 7184287: (prefs) BackingStoreException when calling flush on root node[macosx]

2012-08-27 Thread Kurchi Hazra
This is a request for approval to backport the fix for 7184287 rom 8 to 7u8. Bug:http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7184287 Webrev:http://cr.openjdk.java.net/~khazra/7184287/7u8/webrev.00/ This had been reviewed by Alan Bateman. [1] This fix has been pushed into jdk8 [2]. The

Re: [PATCH] Review request: 6962637 TEST_BUG: java/io/File/MaxPathLength.java may fail in busy system

2012-08-27 Thread Eric Wang
Hi David, Amy & Alan Thanks for your review, Based on your comments I have updated the fix again, Can you please review again? http://dl.dropbox.com/u/90659131/fixes/6962637/webrev/index.html Thanks, Eric On 2012/8/22 17:27, David Holmes wrote: On 22/08/2012 6:10 PM, Eric Wang wrote: Hi Da

Re: [PATCH] Review request: 6962637 TEST_BUG: java/io/File/MaxPathLength.java may fail in busy system

2012-08-27 Thread David Holmes
Hi Eric, So removing the disk space stuff seems fine. Regarding which platform this will run on you have: - removed checks for obsolete windows platforms - enabled the general test to now run on Solaris - changed the test that would only run on windows if -extra was specified to now always run

Re: [PATCH] Review request: 6962637 TEST_BUG: java/io/File/MaxPathLength.java may fail in busy system

2012-08-27 Thread Eric Wang
Hi David, Yes, the 3 items are all the changes. For the -extra option, I also don't know when it should be used, so i prefer to remove it to make sure the long path test on windows could be always executed in Nightly. For the Solaris issue, I have executed the test on several Solaris machines,

Re: RFR [JDK8]: 7169894: JAXP Plugability Layer: using service loader

2012-08-27 Thread Joe Wang
On 8/27/2012 6:19 AM, Alan Bateman wrote: On 24/08/2012 17:52, Joe Wang wrote: Hi, Here is a modified patch: http://cr.openjdk.java.net/~joehw/jdk8/7169894/webrev/ The factory finders contain some format changes, a NetBeans format work. The real changes are as the follows: 1) In factory

Re: RFR [JDK8]: 7169894: JAXP Plugability Layer: using service loader

2012-08-27 Thread Joe Wang
On 8/27/2012 6:19 AM, Paul Sandoz wrote: Hi Joe, This is starting to look cleaner. Yeah, if Alan hasn't asked, I'd sooner keep them as they were :) JAXP is old, I never fancied getting those formats corrected. But I can't do this much to classes I'd update, but probably not to the impl c