I revised the webrev, http://cr.openjdk.java.net/~lancea/8002212/webrev.01,
taking into account the vast majority of Remi's suggestions.
I also added SerialStruct to the webrev.
Have a great weekend.
Best
Lance
On Nov 2, 2012, at 7:42 PM, Remi Forax wrote:
> On 11/02/2012 11:57 PM, Lance Ander
On 11/03/2012 01:46 AM, Lance Andersen - Oracle wrote:
Hi Remi,
[...]
In SerialDataLink, do you really need readObject/writeObject given
that you call the default implementations.
I thought about that but had decided to add them for consistency
The serialization implementation needs to cre
On Nov 3, 2012, at 11:14 AM, Remi Forax wrote:
> On 11/03/2012 01:46 AM, Lance Andersen - Oracle wrote:
>> Hi Remi,
>>
> [...]
>
>>> In SerialDataLink, do you really need readObject/writeObject given
>>> that you call the default implementations.
>> I thought about that but had decided to add t
On 11/03/2012 03:11 PM, Lance Andersen - Oracle wrote:
I revised the webrev, http://cr.openjdk.java.net/~lancea/8002212/webrev.01,
taking into account the vast majority of Remi's suggestions.
in SerialJavaObject, hasStaticFields doesn't work, the original code
doesn't work because
it only che
On Nov 3, 2012, at 11:34 AM, Remi Forax wrote:
> On 11/03/2012 03:11 PM, Lance Andersen - Oracle wrote:
>> I revised the webrev, http://cr.openjdk.java.net/~lancea/8002212/webrev.01,
>> taking into account the vast majority of Remi's suggestions.
>
> in SerialJavaObject, hasStaticFields doesn't
On 11/03/2012 05:23 PM, Lance Andersen - Oracle wrote:
On Nov 3, 2012, at 11:34 AM, Remi Forax wrote:
On 11/03/2012 03:11 PM, Lance Andersen - Oracle wrote:
I revised the webrev, http://cr.openjdk.java.net/~lancea/8002212/webrev.01,
taking into account the vast majority of Remi's suggestions.
Am 30.10.2012 23:40, schrieb Xueming Shen:
I'm "confused" about the order of xxcode() and Xxcoder.
In other places e.g. charsets, we have de... before en..., which is also true
alphabetical
should not be an issue. javadoc output should be in alphabetic order. If it is
really
concerns you, I c
Changeset: ef3ad754f5c7
Author:jjg
Date: 2012-11-03 21:07 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/ef3ad754f5c7
8002146: javadoc doesn't release resources in a timely manner
Reviewed-by: darcy
! src/share/classes/com/sun/tools/javadoc/JavadocMemberEnter.java
! sr
Changeset: 352d130c47c5
Author:jjg
Date: 2012-11-03 21:09 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/352d130c47c5
8002168: Cleanup initialization of javadoc Messager
Reviewed-by: darcy
! src/share/classes/com/sun/tools/javadoc/Start.java
! test/tools/javadoc/695883
