Re: RFR: JDK-8001191: use -source 8 -target 8 when compiling the JDK

2012-11-05 Thread Erik Joelsson
Looks good to me now. /Erik On 2012-11-02 22:00, Kumar Srinivasan wrote: Hi David, Kelly, Erik, as Kelly stated the jdk only build, uses the compiler from the import JDK, this works with -source 8 -target, which was prepped by Joe earlier. I also checked with a jdk only jprt build submission,

Re: bottleneck by java.lang.Class.getAnnotations()

2012-11-05 Thread Alan Bateman
On 04/11/2012 20:27, Peter Levart wrote: : I digress. Javadocs say: "The redefinition may change method bodies, the constant pool and attributes. The redefinition must not add, remove or rename fields or methods, change the signatures of methods, or change inheritance. These restrictions maybe

Re: Preliminary review: Adding tracing of I/O calls

2012-11-05 Thread Chris Hegarty
On 04/11/2012 12:25, Aleksey Shipilev wrote: . class IoTrace { public static final boolean ENABLED = System.getProperty("java.io.trace"); } ...which will demote the flexibility of setListener(), but have much lower runtime overhead. This should be confirmed by microbenchmarking

Re: bottleneck by java.lang.Class.getAnnotations() - proposed patch

2012-11-05 Thread Alexander Knöller
Hi David. What about my proposal for a simple double-checked-locking for the redefinitions fields and the use of local variables for "annotations" in getAnnotations() and initAnnotationsIfNecessary() ? Are additional local Variables similar "bad habit" for memory usage (although they only affect

HashMap / doPrivileged problem

2012-11-05 Thread Salter, Thomas A
I have encountered a problem with initializing the new HashMap code introduced in Java 7u6. I'm running with 7u9. The problem only shows up running rmid (sun.rmi.server.Activation). It seems that the AccessController needs to call HashMap but the new code in HashMap calls AccessController whe

Re: HashMap / doPrivileged problem

2012-11-05 Thread Mike Duigou
Hello Thomas; I am sorry to hear that you ran in to this problem. The class initialization order was something we found to be surprisingly brittle and tricky with this particular change. You've run across a path we didn't anticipate. I have created a bug for this issue : JDK-8002283 (It should

RE: HashMap / doPrivileged problem

2012-11-05 Thread Salter, Thomas A
Mike, Thanks for responding so promptly. I certainly did not expect my fix to be the best one; I was just happy to find something that worked. I couldn't think of a solution that didn't involve doPrivileged and HashMap knowing a lot about each other, like adding a HashMap option just for doPr

hg: jdk8/tl/jdk: 6383200: PBE: need new algorithm support in password based encryption

2012-11-05 Thread vincent . x . ryan
Changeset: 519f4c9ebf8d Author:vinnie Date: 2012-11-05 20:18 + URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/519f4c9ebf8d 6383200: PBE: need new algorithm support in password based encryption Reviewed-by: valeriep ! src/share/classes/com/sun/crypto/provider/PBEKeyFactory.java

hg: jdk8/tl/langtools: 8001112: Make -target 8 in javac generate version 52.0 classfile

2012-11-05 Thread kumar . x . srinivasan
Changeset: 9bce0c73583d Author:ksrini Date: 2012-10-31 10:21 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/9bce0c73583d 8001112: Make -target 8 in javac generate version 52.0 classfile Reviewed-by: darcy, jjg ! src/share/classes/com/sun/tools/javac/jvm/Target.java ! t

Re: bottleneck by java.lang.Class.getAnnotations() - proposed patch

2012-11-05 Thread David Holmes
Hi Alex, On 5/11/2012 11:36 PM, Alexander Knöller wrote: Hi David. What about my proposal for a simple double-checked-locking for the redefinitions fields and the use of local variables for "annotations" in getAnnotations() and initAnnotationsIfNecessary() ? Sorry I thought Peter's proposed

hg: jdk8/tl/jdk: 7197210: java/lang/invoke/CallSiteTest.java failing on armsflt.

2012-11-05 Thread david . holmes
Changeset: cb65e3315b27 Author:jiangli Date: 2012-11-05 12:51 -0500 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/cb65e3315b27 7197210: java/lang/invoke/CallSiteTest.java failing on armsflt. Summary: Reduce work load and set longer timeout for java/lang/invoke tests. Reviewed-by:

Re: bottleneck by java.lang.Class.getAnnotations() - proposed patch

2012-11-05 Thread Peter Levart
Hi all, I have prepared a better patch. It addresses the goals of JEP-149 more seriously. I also have some benchmarks. Stay tuned... Regards, Peter On Nov 6, 2012 2:29 AM, "David Holmes" wrote: > Hi Alex, > > On 5/11/2012 11:36 PM, Alexander Knöller wrote: > >> Hi David. >> >> What about my pro